Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Christopher Faylor <cgf-use-the-mailinglist-please@sourceware.org>
To: Nicolas Roche <roche@adacore.com>,
	gdb-patches@sourceware.org,
		Joel Brobecker <brobecker@adacore.com>
Subject: Re: [RFA/win32] Improve C-c handling when process in different 	console
Date: Sun, 22 Mar 2009 22:16:00 -0000	[thread overview]
Message-ID: <20090322215414.GA2339@ednor.casa.cgf.cx> (raw)
In-Reply-To: <20090316214356.GB384@adacore.com>

On Mon, Mar 16, 2009 at 05:43:56PM -0400, Joel Brobecker wrote:
>> 2008-10-02  Nicolas Roche  <roche@adacore.com>
>> 
>>         * win32-nat.c (check_for_DebugBreakProcess): New function.
>>         (ctrl_c_handler): New function.
>>         (win32_wait): Register ctrl_c_handler as Ctrl-C handler if the inferior
>>         is run in a separate console.
>>         (_initialize_win32_nat): Check for DebugBreakProcess in kernel32.dll.
>
>Here is a new version of the patch. I had to change a couple of things:
>
>  1. Remove the WINBASEAPI when declaring kernel32_DebugBreakProcess;
>     My understanding is that this attribute doesn't make sense at all
>     for a static variable.
>
>  2. Cast the result of GetProcAddress to "void *" in order to avoid
>     a compiler warning. This is consistent with what we do in the other
>     GetProcAddress calls.
>
>This patch has been working very well for us over the past year.
>Do you think you could take a look to see if we can have something in
>before we roll 7.0 out?

I've finally checked in some of (but not all of) the changes that I
wanted to make for dynamically loading functions in windows-nat.c.  That
reduces the size of this patch, which I've now checked in.

cgf


  reply	other threads:[~2009-03-22 21:54 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-02 22:55 Joel Brobecker
2008-10-22 16:45 ` Joel Brobecker
2008-11-12 20:34   ` Christopher Faylor
2008-11-12 20:35     ` Nicolas Roche
2008-11-13 14:40       ` Pierre Muller
2009-03-16 22:11 ` Joel Brobecker
2009-03-22 22:16   ` Christopher Faylor [this message]
2009-03-23 17:15     ` Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090322215414.GA2339@ednor.casa.cgf.cx \
    --to=cgf-use-the-mailinglist-please@sourceware.org \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=roche@adacore.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox