From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4397 invoked by alias); 22 Mar 2009 21:54:30 -0000 Received: (qmail 4389 invoked by uid 22791); 22 Mar 2009 21:54:30 -0000 X-Spam-Check-By: sourceware.org Received: from pool-173-76-58-89.bstnma.fios.verizon.net (HELO cgf.cx) (173.76.58.89) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 22 Mar 2009 21:54:24 +0000 Received: from ednor.cgf.cx (ednor.casa.cgf.cx [192.168.187.5]) by cgf.cx (Postfix) with ESMTP id 0786513C022; Sun, 22 Mar 2009 17:54:15 -0400 (EDT) Received: by ednor.cgf.cx (Postfix, from userid 201) id 01F2E2B385; Sun, 22 Mar 2009 17:54:15 -0400 (EDT) Date: Sun, 22 Mar 2009 22:16:00 -0000 From: Christopher Faylor To: Nicolas Roche , gdb-patches@sourceware.org, Joel Brobecker Subject: Re: [RFA/win32] Improve C-c handling when process in different console Message-ID: <20090322215414.GA2339@ednor.casa.cgf.cx> Mail-Followup-To: Nicolas Roche , gdb-patches@sourceware.org, Joel Brobecker References: <20081002225504.GF26384@adacore.com> <20090316214356.GB384@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090316214356.GB384@adacore.com> User-Agent: Mutt/1.5.16 (2007-06-09) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-03/txt/msg00465.txt.bz2 On Mon, Mar 16, 2009 at 05:43:56PM -0400, Joel Brobecker wrote: >> 2008-10-02 Nicolas Roche >> >> * win32-nat.c (check_for_DebugBreakProcess): New function. >> (ctrl_c_handler): New function. >> (win32_wait): Register ctrl_c_handler as Ctrl-C handler if the inferior >> is run in a separate console. >> (_initialize_win32_nat): Check for DebugBreakProcess in kernel32.dll. > >Here is a new version of the patch. I had to change a couple of things: > > 1. Remove the WINBASEAPI when declaring kernel32_DebugBreakProcess; > My understanding is that this attribute doesn't make sense at all > for a static variable. > > 2. Cast the result of GetProcAddress to "void *" in order to avoid > a compiler warning. This is consistent with what we do in the other > GetProcAddress calls. > >This patch has been working very well for us over the past year. >Do you think you could take a look to see if we can have something in >before we roll 7.0 out? I've finally checked in some of (but not all of) the changes that I wanted to make for dynamically loading functions in windows-nat.c. That reduces the size of this patch, which I've now checked in. cgf