From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: teawater@gmail.com
Cc: gdb-patches@sourceware.org, pedro@codesourcery.com,
marc.khouzam@ericsson.com, msnyder@vmware.com,
bauerman@br.ibm.com, eliz@gnu.org, paawan1982@yahoo.com
Subject: Re: [RFA] Submit process record and replay fourth time, 6/8
Date: Sat, 21 Mar 2009 16:24:00 -0000 [thread overview]
Message-ID: <200903211616.n2LGGepa030032@brahms.sibelius.xs4all.nl> (raw)
In-Reply-To: <daef60380903210903l4fa4e28m57c70bfc714d0754@mail.gmail.com> (message from Hui Zhu on Sun, 22 Mar 2009 00:03:15 +0800)
Sorry for not reviewing things earlier, but sending diffs as base64
encoded MIME attachments makes it less likely I'll look at them.
I think using static variables to pass state is a serious problem with
this diff:
+static int aflag = 1;
+static int dflag = 1;
+static int override = 0;
+static uint8_t modrm;
+static uint8_t mod, reg, rm;
+static int ot;
+static CORE_ADDR i386_record_pc;
next prev parent reply other threads:[~2009-03-21 16:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-21 16:04 Hui Zhu
2009-03-21 16:24 ` Mark Kettenis [this message]
2009-03-23 7:57 ` Hui Zhu
2009-04-15 17:08 ` Hui Zhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200903211616.n2LGGepa030032@brahms.sibelius.xs4all.nl \
--to=mark.kettenis@xs4all.nl \
--cc=bauerman@br.ibm.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=marc.khouzam@ericsson.com \
--cc=msnyder@vmware.com \
--cc=paawan1982@yahoo.com \
--cc=pedro@codesourcery.com \
--cc=teawater@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox