From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19356 invoked by alias); 21 Mar 2009 16:23:13 -0000 Received: (qmail 19326 invoked by uid 22791); 21 Mar 2009 16:23:12 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from sibelius.xs4all.nl (HELO sibelius.xs4all.nl) (82.92.89.47) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 21 Mar 2009 16:23:09 +0000 Received: from brahms.sibelius.xs4all.nl (kettenis@localhost.sibelius.xs4all.nl [127.0.0.1]) by brahms.sibelius.xs4all.nl (8.14.3/8.14.3) with ESMTP id n2LGGga9015797; Sat, 21 Mar 2009 17:16:42 +0100 (CET) Received: (from kettenis@localhost) by brahms.sibelius.xs4all.nl (8.14.3/8.14.3/Submit) id n2LGGepa030032; Sat, 21 Mar 2009 17:16:40 +0100 (CET) Date: Sat, 21 Mar 2009 16:24:00 -0000 Message-Id: <200903211616.n2LGGepa030032@brahms.sibelius.xs4all.nl> From: Mark Kettenis To: teawater@gmail.com CC: gdb-patches@sourceware.org, pedro@codesourcery.com, marc.khouzam@ericsson.com, msnyder@vmware.com, bauerman@br.ibm.com, eliz@gnu.org, paawan1982@yahoo.com In-reply-to: (message from Hui Zhu on Sun, 22 Mar 2009 00:03:15 +0800) Subject: Re: [RFA] Submit process record and replay fourth time, 6/8 References: Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-03/txt/msg00445.txt.bz2 Sorry for not reviewing things earlier, but sending diffs as base64 encoded MIME attachments makes it less likely I'll look at them. I think using static variables to pass state is a serious problem with this diff: +static int aflag = 1; +static int dflag = 1; +static int override = 0; +static uint8_t modrm; +static uint8_t mod, reg, rm; +static int ot; +static CORE_ADDR i386_record_pc;