From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org
Cc: "Alfred M. Szmidt" <ams@gnu.org>, Eli Zaretskii <eliz@gnu.org>,
drow@false.org, nathan@codesourcery.com
Subject: Re: more missing gplv3 notices
Date: Wed, 18 Mar 2009 16:12:00 -0000 [thread overview]
Message-ID: <200903181601.24851.pedro@codesourcery.com> (raw)
In-Reply-To: <E1LjxyR-0002PV-L5@fencepost.gnu.org>
On Wednesday 18 March 2009 15:46:31, Alfred M. Szmidt wrote:
> Sorry, I forgot I shouldn't talk about these things.
>
> Though, to open a can of worms,
>
> | It's important to name the changed function or variable in full.
> | Don't abbreviate function or variable names, and don't combine them.
> | Subsequent maintainers will often search for a function name to find all
> | the change log entries that pertain to it; if you abbreviate the name,
> | they won't find it when they search.
> |
> | For example, some people are tempted to abbreviate groups of function
> | names by writing `* register.el ({insert,jump-to}-register)'; this is
> | not a good idea, since searching for `jump-to-register' or
> | `insert-register' would not find that entry.
And which part of:
* Makefile.in, ada-exp.y, ada-lex.l, c-exp.y, cp-name-parser.y,
darwin-nat-info.c, f-exp.y, gdb_thread_db.h, hppanbsd-nat.c,
hppanbsd-tdep.c, hppaobsd-tdep.c, jv-exp.y, m2-exp.y, objc-exp.y,
p-exp.y, reply_mig_hack.awk, reverse.c, xtensa-xtregs.c: Update
license to GPLv3.
has any abbreviation, compared to:
* Makefile.in: Update license to GPLv3.
* ada-exp.y: Update license to GPLv3.
* ada-lex.l: Update license to GPLv3.
...
?
I can't see the point you're making.
We should not abbreviate, since then grepping would miss the
abbreviated forms. But I fail to see how the former form
has any disadvantage over the latter. I certainly have used
the former form before many times, and it looks like I'm not the
only one. Just try this to see for yourself:
>cd gdb
>grep "\.c," ChangeLog*
?
I've grepped changelogs for changes to a file before, and never
before have I thought that I'd prefer people used the latter
form "'cause I was missing things".
--
Pedro Alves
next prev parent reply other threads:[~2009-03-18 16:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-16 9:49 Nathan Sidwell
2009-03-16 19:32 ` Eli Zaretskii
2009-03-17 11:36 ` Nathan Sidwell
2009-03-17 19:04 ` Eli Zaretskii
2009-03-17 19:28 ` Daniel Jacobowitz
2009-03-17 20:03 ` Eli Zaretskii
2009-03-18 16:01 ` Alfred M. Szmidt
2009-03-18 16:12 ` Pedro Alves [this message]
2009-03-18 16:33 ` Alfred M. Szmidt
2009-03-18 19:24 ` Pedro Alves
2009-03-18 11:05 ` Nathan Sidwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200903181601.24851.pedro@codesourcery.com \
--to=pedro@codesourcery.com \
--cc=ams@gnu.org \
--cc=drow@false.org \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=nathan@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox