From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26304 invoked by alias); 18 Mar 2009 16:01:28 -0000 Received: (qmail 25858 invoked by uid 22791); 18 Mar 2009 16:01:26 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00,J_CHICKENPOX_82,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 18 Mar 2009 16:01:21 +0000 Received: (qmail 12983 invoked from network); 18 Mar 2009 16:01:19 -0000 Received: from unknown (HELO orlando) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 18 Mar 2009 16:01:19 -0000 From: Pedro Alves To: gdb-patches@sourceware.org Subject: Re: more missing gplv3 notices Date: Wed, 18 Mar 2009 16:12:00 -0000 User-Agent: KMail/1.9.10 Cc: "Alfred M. Szmidt" , Eli Zaretskii , drow@false.org, nathan@codesourcery.com References: <49BE06F6.3090008@codesourcery.com> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Message-Id: <200903181601.24851.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-03/txt/msg00383.txt.bz2 On Wednesday 18 March 2009 15:46:31, Alfred M. Szmidt wrote: > =A0 =A0Sorry, I forgot I shouldn't talk about these things. >=20 > Though, to open a can of worms, >=20 > | =A0 =A0It's important to name the changed function or variable in full. > | Don't abbreviate function or variable names, and don't combine them. > | Subsequent maintainers will often search for a function name to find all > | the change log entries that pertain to it; if you abbreviate the name, > | they won't find it when they search. > |=20 > | =A0 =A0For example, some people are tempted to abbreviate groups of fun= ction > | names by writing `* register.el ({insert,jump-to}-register)'; this is > | not a good idea, since searching for `jump-to-register' or > | `insert-register' would not find that entry. And which part of: * Makefile.in, ada-exp.y, ada-lex.l, c-exp.y, cp-name-parser.y, darwin-nat-info.c, f-exp.y, gdb_thread_db.h, hppanbsd-nat.c, hppanbsd-tdep.c, hppaobsd-tdep.c, jv-exp.y, m2-exp.y, objc-exp.y, p-exp.y, reply_mig_hack.awk, reverse.c, xtensa-xtregs.c: Update license to GPLv3. has any abbreviation, compared to: * Makefile.in: Update license to GPLv3. * ada-exp.y: Update license to GPLv3. * ada-lex.l: Update license to GPLv3. ... ? I can't see the point you're making. We should not abbreviate, since then grepping would miss the abbreviated forms. But I fail to see how the former form has any disadvantage over the latter. I certainly have used the former form before many times, and it looks like I'm not the only one. Just try this to see for yourself: >cd gdb >grep "\.c," ChangeLog*=20 ? I've grepped changelogs for changes to a file before, and never before have I thought that I'd prefer people used the latter form "'cause I was missing things". --=20 Pedro Alves