From: Joel Brobecker <brobecker@adacore.com>
To: Kevin Buettner <kevinb@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFC] mn10300: Rewrite prologue analyzer
Date: Mon, 16 Mar 2009 17:31:00 -0000 [thread overview]
Message-ID: <20090316172438.GG9294@adacore.com> (raw)
In-Reply-To: <20090313162450.31a77332@redhat.com>
> I've rewritten the prologue analyzer to use the "prologue-value"
> machinery. It already knows about more instructions than the existing
> prologue analyzer, and will accept instructions in any order.
Nice! I've always wanted to take a look and see how it can simplify
prologue parsing... How did you find it?
Looks like overall your patch is a nice improvement compared to
the previous implementation. I quickly scanned the patch. I am not
very familiar with prologue-value, but everything seemed OK to me.
--
Joel
next prev parent reply other threads:[~2009-03-16 17:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-13 23:25 Kevin Buettner
2009-03-16 17:31 ` Joel Brobecker [this message]
2009-03-18 5:27 ` Kevin Buettner
2009-03-25 16:21 ` Kevin Buettner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090316172438.GG9294@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=kevinb@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox