From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26236 invoked by alias); 16 Mar 2009 17:24:53 -0000 Received: (qmail 26203 invoked by uid 22791); 16 Mar 2009 17:24:50 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 16 Mar 2009 17:24:45 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 80FF02BAB90; Mon, 16 Mar 2009 13:24:39 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id ga9e0URzlbZ9; Mon, 16 Mar 2009 13:24:39 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 6B0592BAB8C; Mon, 16 Mar 2009 13:24:39 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 7BA21F5C40; Mon, 16 Mar 2009 10:24:38 -0700 (PDT) Date: Mon, 16 Mar 2009 17:31:00 -0000 From: Joel Brobecker To: Kevin Buettner Cc: gdb-patches@sourceware.org Subject: Re: [RFC] mn10300: Rewrite prologue analyzer Message-ID: <20090316172438.GG9294@adacore.com> References: <20090313162450.31a77332@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090313162450.31a77332@redhat.com> User-Agent: Mutt/1.5.18 (2008-05-17) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-03/txt/msg00270.txt.bz2 > I've rewritten the prologue analyzer to use the "prologue-value" > machinery. It already knows about more instructions than the existing > prologue analyzer, and will accept instructions in any order. Nice! I've always wanted to take a look and see how it can simplify prologue parsing... How did you find it? Looks like overall your patch is a nice improvement compared to the previous implementation. I quickly scanned the patch. I am not very familiar with prologue-value, but everything seemed OK to me. -- Joel