Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Pedro Alves <pedro@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [commit/AIX] Debugger is crashing when debugging program
Date: Sun, 15 Mar 2009 23:46:00 -0000	[thread overview]
Message-ID: <20090315210746.GC9294@adacore.com> (raw)
In-Reply-To: <20090315203742.GB9294@adacore.com>

[-- Attachment #1: Type: text/plain, Size: 604 bytes --]

> > I'm curious, why &current_target here instead of 'ops'?  This will call
> > aix_thread_thread_alive  and aix_thread_pid_to_str two times, as
> > current_target.beneath == aix_thread.
> 
> !!! Typo. Will fix immediately.

Fixed thusly.

2009-03-15  Joel Brobecker  <brobecker@adacore.com>

        * aix-thread.c (aix_thread_thread_alive, aix_thread_pid_to_str):
        Use the ops parameter to get to the target beneath, rather than
        using the current_target global.  Using the current_target global
        was an accident.

Tested on powerpc-aix. Checked in.

Thanks again, Pedro.
-- 
Joel

[-- Attachment #2: aix-thread.diff --]
[-- Type: text/x-diff, Size: 840 bytes --]

Index: aix-thread.c
===================================================================
--- aix-thread.c	(revision 146289)
+++ aix-thread.c	(working copy)
@@ -1676,7 +1676,7 @@ aix_thread_mourn_inferior (struct target
 static int
 aix_thread_thread_alive (struct target_ops *ops, ptid_t ptid)
 {
-  struct target_ops *beneath = find_target_beneath (&current_target);
+  struct target_ops *beneath = find_target_beneath (ops);
 
   if (!PD_TID (ptid))
     return beneath->to_thread_alive (beneath, ptid);
@@ -1693,7 +1693,7 @@ static char *
 aix_thread_pid_to_str (struct target_ops *ops, ptid_t ptid)
 {
   static char *ret = NULL;
-  struct target_ops *beneath = find_target_beneath (&current_target);
+  struct target_ops *beneath = find_target_beneath (ops);
 
   if (!PD_TID (ptid))
     return beneath->to_pid_to_str (beneath, ptid);

      reply	other threads:[~2009-03-15 21:18 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-15 19:46 Joel Brobecker
2009-03-15 20:33 ` Pedro Alves
2009-03-15 20:38   ` Joel Brobecker
2009-03-15 23:46     ` Joel Brobecker [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090315210746.GC9294@adacore.com \
    --to=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=pedro@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox