From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org
Cc: Joel Brobecker <brobecker@adacore.com>
Subject: Re: [commit/AIX] Debugger is crashing when debugging program
Date: Sun, 15 Mar 2009 20:33:00 -0000 [thread overview]
Message-ID: <200903151958.36564.pedro@codesourcery.com> (raw)
In-Reply-To: <20090315194428.GA9576@adacore.com>
On Sunday 15 March 2009 19:44:28, Joel Brobecker wrote:
> static int
> aix_thread_thread_alive (struct target_ops *ops, ptid_t ptid)
> {
> + struct target_ops *beneath = find_target_beneath (¤t_target);
> +
> if (!PD_TID (ptid))
> - return base_target.to_thread_alive (ops, ptid);
> + return beneath->to_thread_alive (beneath, ptid);
>
> @@ -1698,9 +1693,10 @@ static char *
> aix_thread_pid_to_str (struct target_ops *ops, ptid_t ptid)
> {
> static char *ret = NULL;
> + struct target_ops *beneath = find_target_beneath (¤t_target);
I'm curious, why ¤t_target here instead of 'ops'? This will call
aix_thread_thread_alive and aix_thread_pid_to_str two times, as
current_target.beneath == aix_thread.
--
Pedro Alves
next prev parent reply other threads:[~2009-03-15 20:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-15 19:46 Joel Brobecker
2009-03-15 20:33 ` Pedro Alves [this message]
2009-03-15 20:38 ` Joel Brobecker
2009-03-15 23:46 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200903151958.36564.pedro@codesourcery.com \
--to=pedro@codesourcery.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox