Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] testsuite: Fix a racy FAIL on gdb.base/multi-forks.exp
Date: Sat, 14 Mar 2009 21:45:00 -0000	[thread overview]
Message-ID: <20090314142758.GA9790@host0.dyn.jankratochvil.net> (raw)
In-Reply-To: <20090313230033.GB30693@adacore.com>

On Sat, 14 Mar 2009 00:00:33 +0100, Joel Brobecker wrote:
> > gdb/testsuite/
> > 2009-03-13  Jan Kratochvil  <jan.kratochvil@redhat.com>
> > 
> > 	Fix a racy FAIL.
> > 	* gdb.base/multi-forks.exp (continue_to_exit_bp_loc): New function with
> > 	code from `follow parent, print pids'.
> > 	(`follow child, print pids', `follow parent, print pids'): Call it.
> > 	Replace `gdb_test "break..."' by gdb_breakpoint.
> 
> This seems pretty reasonable to me...

Checked-in: http://sourceware.org/ml/gdb-cvs/2009-03/msg00090.html


> I am so sorry to be picking on your comments. I very much appreciate
> the fact that you spend the time writing them, especially since most
> people tend to not write comments. In this case, this comments also
> sounds strange. Here is a suggestion:

Used your text.  I will give the same effort on the comments as on user
visible texts.


Thanks,
Jan


  reply	other threads:[~2009-03-14 14:28 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-13 16:01 Jan Kratochvil
2009-03-13 16:47 ` Joel Brobecker
2009-03-13 21:02   ` Jan Kratochvil
2009-03-13 23:11     ` Joel Brobecker
2009-03-14 21:45       ` Jan Kratochvil [this message]
2009-03-14 12:32   ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090314142758.GA9790@host0.dyn.jankratochvil.net \
    --to=jan.kratochvil@redhat.com \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox