From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5314 invoked by alias); 14 Mar 2009 14:28:36 -0000 Received: (qmail 5306 invoked by uid 22791); 14 Mar 2009 14:28:35 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx2.redhat.com (HELO mx2.redhat.com) (66.187.237.31) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 14 Mar 2009 14:28:28 +0000 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n2EES4Zh001063; Sat, 14 Mar 2009 10:28:04 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n2EES3tJ010875; Sat, 14 Mar 2009 10:28:03 -0400 Received: from host0.dyn.jankratochvil.net (sebastian-int.corp.redhat.com [172.16.52.221]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n2EES1xH022504; Sat, 14 Mar 2009 10:28:02 -0400 Received: from host0.dyn.jankratochvil.net (localhost [127.0.0.1]) by host0.dyn.jankratochvil.net (8.14.3/8.14.3) with ESMTP id n2EERx7m010087; Sat, 14 Mar 2009 15:27:59 +0100 Received: (from jkratoch@localhost) by host0.dyn.jankratochvil.net (8.14.3/8.14.2/Submit) id n2EERwS6010084; Sat, 14 Mar 2009 15:27:58 +0100 Date: Sat, 14 Mar 2009 21:45:00 -0000 From: Jan Kratochvil To: Joel Brobecker Cc: gdb-patches@sourceware.org Subject: Re: [patch] testsuite: Fix a racy FAIL on gdb.base/multi-forks.exp Message-ID: <20090314142758.GA9790@host0.dyn.jankratochvil.net> References: <20090313152723.GA13673@host0.dyn.jankratochvil.net> <20090313161423.GF8368@adacore.com> <20090313194932.GA5597@host0.dyn.jankratochvil.net> <20090313230033.GB30693@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090313230033.GB30693@adacore.com> User-Agent: Mutt/1.5.18 (2008-05-17) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-03/txt/msg00231.txt.bz2 On Sat, 14 Mar 2009 00:00:33 +0100, Joel Brobecker wrote: > > gdb/testsuite/ > > 2009-03-13 Jan Kratochvil > > > > Fix a racy FAIL. > > * gdb.base/multi-forks.exp (continue_to_exit_bp_loc): New function with > > code from `follow parent, print pids'. > > (`follow child, print pids', `follow parent, print pids'): Call it. > > Replace `gdb_test "break..."' by gdb_breakpoint. > > This seems pretty reasonable to me... Checked-in: http://sourceware.org/ml/gdb-cvs/2009-03/msg00090.html > I am so sorry to be picking on your comments. I very much appreciate > the fact that you spend the time writing them, especially since most > people tend to not write comments. In this case, this comments also > sounds strange. Here is a suggestion: Used your text. I will give the same effort on the comments as on user visible texts. Thanks, Jan