Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] Correct `gcc -D' macros get ignored (PR 9873)
Date: Mon, 09 Mar 2009 18:56:00 -0000	[thread overview]
Message-ID: <20090309185548.GA28205@host0.dyn.jankratochvil.net> (raw)
In-Reply-To: <20090309184138.GB4561@adacore.com>

On Mon, 09 Mar 2009 19:41:38 +0100, Joel Brobecker wrote:
> > Sure I find your text better although its first line does not follow the GNU
> > Coding Style directive `[...] please write complete sentences [...]'.
> > Used your text.
> 
> Are you refering to the "First pass:"? I think it's OK.

Yes; OK.


Checked-in: http://sourceware.org/ml/gdb-cvs/2009-03/msg00041.html

A testcase (to verify it still works wrt current gcc) is left for review in:
[patch] Better display command-line macros + doc addon
http://sourceware.org/ml/gdb-patches/2009-03/msg00104.html


Thanks for the review,
Jan


      reply	other threads:[~2009-03-09 18:56 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-20  0:20 Jan Kratochvil
     [not found] ` <20090228071514.GA25299@adacore.com>
     [not found]   ` <20090228100225.GA15788@host0.dyn.jankratochvil.net>
2009-03-03  0:54     ` Joel Brobecker
2009-03-09  0:57       ` Jan Kratochvil
2009-03-09 18:41         ` Joel Brobecker
2009-03-09 18:56           ` Jan Kratochvil [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090309185548.GA28205@host0.dyn.jankratochvil.net \
    --to=jan.kratochvil@redhat.com \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox