From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4373 invoked by alias); 9 Mar 2009 18:56:29 -0000 Received: (qmail 4361 invoked by uid 22791); 9 Mar 2009 18:56:28 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx2.redhat.com (HELO mx2.redhat.com) (66.187.237.31) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 09 Mar 2009 18:56:20 +0000 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n29Itsqd006159; Mon, 9 Mar 2009 14:55:54 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n29ItssQ031478; Mon, 9 Mar 2009 14:55:54 -0400 Received: from host0.dyn.jankratochvil.net (sebastian-int.corp.redhat.com [172.16.52.221]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n29Itqf9009267; Mon, 9 Mar 2009 14:55:53 -0400 Received: from host0.dyn.jankratochvil.net (localhost [127.0.0.1]) by host0.dyn.jankratochvil.net (8.14.3/8.14.3) with ESMTP id n29ItmPg029071; Mon, 9 Mar 2009 19:55:49 +0100 Received: (from jkratoch@localhost) by host0.dyn.jankratochvil.net (8.14.3/8.14.2/Submit) id n29ItmcG029068; Mon, 9 Mar 2009 19:55:48 +0100 Date: Mon, 09 Mar 2009 18:56:00 -0000 From: Jan Kratochvil To: Joel Brobecker Cc: gdb-patches@sourceware.org Subject: Re: [patch] Correct `gcc -D' macros get ignored (PR 9873) Message-ID: <20090309185548.GA28205@host0.dyn.jankratochvil.net> References: <20090219214540.GA32244@host0.dyn.jankratochvil.net> <20090228071514.GA25299@adacore.com> <20090228100225.GA15788@host0.dyn.jankratochvil.net> <20090303005430.GL26056@adacore.com> <20090309005707.GB29150@host0.dyn.jankratochvil.net> <20090309184138.GB4561@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090309184138.GB4561@adacore.com> User-Agent: Mutt/1.5.18 (2008-05-17) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-03/txt/msg00120.txt.bz2 On Mon, 09 Mar 2009 19:41:38 +0100, Joel Brobecker wrote: > > Sure I find your text better although its first line does not follow the GNU > > Coding Style directive `[...] please write complete sentences [...]'. > > Used your text. > > Are you refering to the "First pass:"? I think it's OK. Yes; OK. Checked-in: http://sourceware.org/ml/gdb-cvs/2009-03/msg00041.html A testcase (to verify it still works wrt current gcc) is left for review in: [patch] Better display command-line macros + doc addon http://sourceware.org/ml/gdb-patches/2009-03/msg00104.html Thanks for the review, Jan