From: dje@google.com (Doug Evans)
To: gdb-patches@sourceware.org
Subject: [ob] Clean up output of overlay bkpt insertion error message
Date: Thu, 26 Feb 2009 17:59:00 -0000 [thread overview]
Message-ID: <20090226011711.755AE1C78A4@localhost> (raw)
Hi.
I checked this in under the obvious rule.
Without the patch I was getting:
Warning:
Overlay breakpoint 1 failed: in ROM?Cannot insert breakpoint 1.
Error accessing memory address 0x102e0: Input/output error.
Both the line I changed and the preceding line had a trailing space,
so I removed that too.
2009-02-25 Doug Evans <dje@google.com>
* breakpoint.c (insert_bp_location): Add \n to overlay breakpoint
error message.
diff -u -p -u -p -r1.379 breakpoint.c
--- breakpoint.c 25 Feb 2009 21:43:04 -0000 1.379
+++ breakpoint.c 26 Feb 2009 01:12:37 -0000
@@ -1135,8 +1135,8 @@ Note: automatically using hardware break
bpt->overlay_target_info.placed_address = addr;
val = target_insert_breakpoint (&bpt->overlay_target_info);
if (val != 0)
- fprintf_unfiltered (tmp_error_stream,
- "Overlay breakpoint %d failed: in ROM?",
+ fprintf_unfiltered (tmp_error_stream,
+ "Overlay breakpoint %d failed: in ROM?\n",
bpt->owner->number);
}
}
reply other threads:[~2009-02-26 1:17 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090226011711.755AE1C78A4@localhost \
--to=dje@google.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox