From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32068 invoked by alias); 26 Feb 2009 01:17:21 -0000 Received: (qmail 32060 invoked by uid 22791); 26 Feb 2009 01:17:21 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,J_CHICKENPOX_36,SPF_PASS X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.45.13) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 26 Feb 2009 01:17:14 +0000 Received: from zps76.corp.google.com (zps76.corp.google.com [172.25.146.76]) by smtp-out.google.com with ESMTP id n1Q1HCRB020902 for ; Wed, 25 Feb 2009 17:17:12 -0800 Received: from localhost (ruffy.corp.google.com [172.18.118.116]) by zps76.corp.google.com with ESMTP id n1Q1HBQI008834 for ; Wed, 25 Feb 2009 17:17:11 -0800 Received: by localhost (Postfix, from userid 67641) id 755AE1C78A4; Wed, 25 Feb 2009 17:17:10 -0800 (PST) To: gdb-patches@sourceware.org Subject: [ob] Clean up output of overlay bkpt insertion error message Message-Id: <20090226011711.755AE1C78A4@localhost> Date: Thu, 26 Feb 2009 17:59:00 -0000 From: dje@google.com (Doug Evans) X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-02/txt/msg00484.txt.bz2 Hi. I checked this in under the obvious rule. Without the patch I was getting: Warning: Overlay breakpoint 1 failed: in ROM?Cannot insert breakpoint 1. Error accessing memory address 0x102e0: Input/output error. Both the line I changed and the preceding line had a trailing space, so I removed that too. 2009-02-25 Doug Evans * breakpoint.c (insert_bp_location): Add \n to overlay breakpoint error message. diff -u -p -u -p -r1.379 breakpoint.c --- breakpoint.c 25 Feb 2009 21:43:04 -0000 1.379 +++ breakpoint.c 26 Feb 2009 01:12:37 -0000 @@ -1135,8 +1135,8 @@ Note: automatically using hardware break bpt->overlay_target_info.placed_address = addr; val = target_insert_breakpoint (&bpt->overlay_target_info); if (val != 0) - fprintf_unfiltered (tmp_error_stream, - "Overlay breakpoint %d failed: in ROM?", + fprintf_unfiltered (tmp_error_stream, + "Overlay breakpoint %d failed: in ROM?\n", bpt->owner->number); } }