[RFA] gdbserver: also issue remote debug information for getpkt in no-ack-mode

[RFA] gdbserver: also issue remote debug information for getpkt in no-ack-mode

[Pierre Muller]

  gdbserver with --remote-debug
only prints out putpkt information
if noack_mode is set.
  getpkt debug information is only printed out
if noack_mode is zero.

  The following patch also issues
getpkt debug information if noack_mode is non-zero.  

  Is this OK?

  I am still not capable of running
a testsuite for gdbserver...
  thus I can't give you any results on
the testsuite.

  Could someone tell me how to setup a
dejagnu target to run the testsuite 
with cygwin gdbserver on a cygwin machine?


Pierre Muller
Pascal language support maintainer for GDB


gdbserver/ChangeLog entry:

2009-02-09  Pierre Muller  <muller@ics.u-strasbg.fr>

	* remote-utils.c (getpkt): Also generate remote-debug
	information if noack_mode is set.

  




Index: gdb/gdbserver/remote-utils.c
===================================================================
RCS file: /cvs/src/src/gdb/gdbserver/remote-utils.c,v
retrieving revision 1.60
diff -u -p -r1.60 remote-utils.c
--- gdb/gdbserver/remote-utils.c	3 Jan 2009 05:57:57 -0000	1.60
+++ gdb/gdbserver/remote-utils.c	9 Feb 2009 15:44:54 -0000
@@ -823,6 +823,15 @@ getpkt (char *buf)
 	  fflush (stderr);
 	}
     }
+  else
+    {
+      if (remote_debug)
+	{
+	  fprintf (stderr, "getpkt (\"%s\");  [no ack sent] \n", buf);
+	  fflush (stderr);
+	}
+
+    }
 
   return bp - buf;
 }

Re: [RFA] gdbserver: also issue remote debug information for getpkt in no-ack-mode

[Pedro Alves]

On Monday 09 February 2009 16:04:08, Pierre Muller wrote:

>   Is this OK?

Looks good to me (tiny comment in the patch below).  I thought I
had already fixed this in HEAD, but I see the fix done in
the multi-process branch only.  :-)

>   Could someone tell me how to setup a
> dejagnu target to run the testsuite 
> with cygwin gdbserver on a cygwin machine?

See here:

 http://sourceware.org/gdb/wiki/Native_gdbserver_testing

This works on Cygwin, as I use this method there.

> +  else
> +    {
> +      if (remote_debug)
> +	{
> +	  fprintf (stderr, "getpkt (\"%s\");  [no ack sent] \n", buf);
> +	  fflush (stderr);
> +	}
> +

Spurious blank line here.

> +    }
>  

-- 
Pedro Alves

RE: [RFA] gdbserver: also issue remote debug information for getpkt in no-ack-mode

[Pierre Muller]

Thanks, Pedro,
I committed the patch without that spurious empty line.


Pierre Muller
Pascal language support maintainer for GDB




> -----Message d'origine-----
> De : gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] De la part de Pedro Alves
> Envoyé : Saturday, February 14, 2009 12:49 AM
> À : gdb-patches@sourceware.org
> Cc : Pierre Muller
> Objet : Re: [RFA] gdbserver: also issue remote debug information for
> getpkt in no-ack-mode
> 
> On Monday 09 February 2009 16:04:08, Pierre Muller wrote:
> 
> >   Is this OK?
> 
> Looks good to me (tiny comment in the patch below).  I thought I
> had already fixed this in HEAD, but I see the fix done in
> the multi-process branch only.  :-)
> 
> >   Could someone tell me how to setup a
> > dejagnu target to run the testsuite
> > with cygwin gdbserver on a cygwin machine?
> 
> See here:
> 
>  http://sourceware.org/gdb/wiki/Native_gdbserver_testing
> 
> This works on Cygwin, as I use this method there.
> 
> > +  else
> > +    {
> > +      if (remote_debug)
> > +	{
> > +	  fprintf (stderr, "getpkt (\"%s\");  [no ack sent] \n", buf);
> > +	  fflush (stderr);
> > +	}
> > +
> 
> Spurious blank line here.
> 
> > +    }
> >
> 
> --
> Pedro Alves

RE: [RFA] gdbserver: also issue remote debug information for getpkt in no-ack-mode

[Pierre Muller]

> >   Could someone tell me how to setup a
> > dejagnu target to run the testsuite
> > with cygwin gdbserver on a cygwin machine?
> 
> See here:
> 
>  http://sourceware.org/gdb/wiki/Native_gdbserver_testing

 Thanks a lot,
I followed the instructions, 
removed the line that disabled hardware watchpoints
and was able to check that 
gdb.base/watchpoint.exp
works with my two patches, great!

Thanks, Pedro,

Pierre