From: Daniel Jacobowitz <drow@false.org>
To: "Sérgio Durigan Júnior" <sergiodj@linux.vnet.ibm.com>
Cc: gdb-patches@sourceware.org, teawater <teawater@gmail.com>
Subject: Re: [PATCH 2/4] catch syscall -- try 4 -- Architecture-dependent part
Date: Sun, 01 Feb 2009 19:40:00 -0000 [thread overview]
Message-ID: <20090201194008.GK4597@caradoc.them.org> (raw)
In-Reply-To: <1232929833.26873.23.camel@miki>
You might as well just test for PTRACE_O_TRACESYSGOOD, and enable it,
at the same time as all the other tests. That'll remove a bunch of
new code, including current_ptrace_options. Even if we do need to
delay system call tracing until some point in execution, that does not
apply to PTRACE_O_TRACESYSGOOD; it can be safely set right away since
it only has any effect once you use PTRACE_SYSCALL.
Other than that, everything I saw in this patch I already described in
my review of patch 1 (entry point check, XML syscalls in non-Linux
code).
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2009-02-01 19:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-26 0:31 Sérgio Durigan Júnior
2009-02-01 19:40 ` Daniel Jacobowitz [this message]
[not found] <200901261836.n0QIaKv7027857@pctc1.boeblingen.de.ibm.com>
2009-01-26 18:52 ` Sérgio Durigan Júnior
2009-01-26 18:59 ` Sérgio Durigan Júnior
2009-01-26 19:35 ` Ulrich Weigand
2009-01-26 19:45 ` Sérgio Durigan Júnior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090201194008.GK4597@caradoc.them.org \
--to=drow@false.org \
--cc=gdb-patches@sourceware.org \
--cc=sergiodj@linux.vnet.ibm.com \
--cc=teawater@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox