From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29076 invoked by alias); 1 Feb 2009 19:40:19 -0000 Received: (qmail 29066 invoked by uid 22791); 1 Feb 2009 19:40:18 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 01 Feb 2009 19:40:10 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id B244510815; Sun, 1 Feb 2009 19:40:08 +0000 (GMT) Received: from caradoc.them.org (209.195.188.212.nauticom.net [209.195.188.212]) by nan.false.org (Postfix) with ESMTP id A33F0107F4; Sun, 1 Feb 2009 19:40:08 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1LTiAq-0002zZ-7i; Sun, 01 Feb 2009 14:40:08 -0500 Date: Sun, 01 Feb 2009 19:40:00 -0000 From: Daniel Jacobowitz To: =?iso-8859-1?Q?S=E9rgio_Durigan_J=FAnior?= Cc: gdb-patches@sourceware.org, teawater Subject: Re: [PATCH 2/4] catch syscall -- try 4 -- Architecture-dependent part Message-ID: <20090201194008.GK4597@caradoc.them.org> Mail-Followup-To: =?iso-8859-1?Q?S=E9rgio_Durigan_J=FAnior?= , gdb-patches@sourceware.org, teawater References: <1232929833.26873.23.camel@miki> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1232929833.26873.23.camel@miki> User-Agent: Mutt/1.5.17 (2008-05-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-02/txt/msg00011.txt.bz2 You might as well just test for PTRACE_O_TRACESYSGOOD, and enable it, at the same time as all the other tests. That'll remove a bunch of new code, including current_ptrace_options. Even if we do need to delay system call tracing until some point in execution, that does not apply to PTRACE_O_TRACESYSGOOD; it can be safely set right away since it only has any effect once you use PTRACE_SYSCALL. Other than that, everything I saw in this patch I already described in my review of patch 1 (entry point check, XML syscalls in non-Linux code). -- Daniel Jacobowitz CodeSourcery