From: Daniel Jacobowitz <drow@false.org>
To: Doug Evans <dje@google.com>
Cc: gdb-patches@sourceware.org, keiths@redhat.com
Subject: Re: [RFA] fixes to building gdb w/gdbtk and w/o tcl/tk
Date: Sun, 01 Feb 2009 17:56:00 -0000 [thread overview]
Message-ID: <20090201175619.GB4597@caradoc.them.org> (raw)
In-Reply-To: <20090130203615.A82971C7A17@localhost>
On Fri, Jan 30, 2009 at 12:36:15PM -0800, Doug Evans wrote:
> + if test -z "${no_tcl}" -a -z "${no_tk}"; then
Please use "&& test" instead of "-a"; it's more portable that way.
> - BUILD_TCLSH=${TCL_BIN_DIR}/tclsh
> + BUILD_TCLSH="${TCL_BIN_DIR}/tclsh"
For the record I'm pretty sure you don't need quotes after '='.
Otherwise seems OK. When you're reindenting a lot, also attaching a
whitespace-insensitive diff makes things a lot easier, though.
--
Daniel Jacobowitz
CodeSourcery
prev parent reply other threads:[~2009-02-01 17:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-30 23:17 Doug Evans
2009-02-01 17:56 ` Daniel Jacobowitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090201175619.GB4597@caradoc.them.org \
--to=drow@false.org \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=keiths@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox