From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7969 invoked by alias); 1 Feb 2009 17:56:26 -0000 Received: (qmail 7961 invoked by uid 22791); 1 Feb 2009 17:56:26 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 01 Feb 2009 17:56:21 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id E5D88107F8; Sun, 1 Feb 2009 17:56:19 +0000 (GMT) Received: from caradoc.them.org (209.195.188.212.nauticom.net [209.195.188.212]) by nan.false.org (Postfix) with ESMTP id C8618107F6; Sun, 1 Feb 2009 17:56:19 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1LTgYN-0001Hc-7V; Sun, 01 Feb 2009 12:56:19 -0500 Date: Sun, 01 Feb 2009 17:56:00 -0000 From: Daniel Jacobowitz To: Doug Evans Cc: gdb-patches@sourceware.org, keiths@redhat.com Subject: Re: [RFA] fixes to building gdb w/gdbtk and w/o tcl/tk Message-ID: <20090201175619.GB4597@caradoc.them.org> Mail-Followup-To: Doug Evans , gdb-patches@sourceware.org, keiths@redhat.com References: <20090130203615.A82971C7A17@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090130203615.A82971C7A17@localhost> User-Agent: Mutt/1.5.17 (2008-05-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-02/txt/msg00001.txt.bz2 On Fri, Jan 30, 2009 at 12:36:15PM -0800, Doug Evans wrote: > + if test -z "${no_tcl}" -a -z "${no_tk}"; then Please use "&& test" instead of "-a"; it's more portable that way. > - BUILD_TCLSH=${TCL_BIN_DIR}/tclsh > + BUILD_TCLSH="${TCL_BIN_DIR}/tclsh" For the record I'm pretty sure you don't need quotes after '='. Otherwise seems OK. When you're reindenting a lot, also attaching a whitespace-insensitive diff makes things a lot easier, though. -- Daniel Jacobowitz CodeSourcery