[commit] Fix for PR9664.

[commit] Fix for PR9664.

[Pedro Alves]

[-- Attachment #1: Type: text/plain, Size: 883 bytes --]

This fixes PR9664 <http://sourceware.org/bugzilla/show_bug.cgi?id=9664>,
which was a regression I introduced here:

 http://sourceware.org/ml/gdb-patches/2008-09/msg00193.html

The regression is about the fact that the hook-stop in normal_stop
was now being run after frame printing, while it is documented as
being run before.

 "(@samp{hook-stop}) makes the associated commands execute every time
 execution stops in your program: before breakpoint commands are run,
 displays are printed, or the stack frame is printed."

The fix is to put the hook-stop where it was before.  To re-fix
the original issue described in the email pointed above, I moved the
tagging threads as stopped a bit higher up as well.

I've also added a new test so future changes don't miss
this hook-stop-before-print-stack-frame rule.

Tested on x86_64-linux, sync/async, and checked in.

-- 
Pedro Alves

[-- Attachment #2: pr9664_hook_stop.diff --]
[-- Type: text/x-diff, Size: 5102 bytes --]

2009-01-23  Pedro Alves  <pedro@codesourcery.com>

	PR gdb/9664:
	* infrun.c (normal_stop): Tag threads as stopped, and run the
	hook-stop before printing the stack frame.

2009-01-23  Pedro Alves  <pedro@codesourcery.com>

	PR gdb/9664:
	* gdb.base/hook-stop-frame.c, gdb.base/hook-stop-frame.exp: New.

---
 gdb/infrun.c                               |   19 ++++------
 gdb/testsuite/gdb.base/hook-stop-frame.c   |   32 ++++++++++++++++
 gdb/testsuite/gdb.base/hook-stop-frame.exp |   55 +++++++++++++++++++++++++++++
 3 files changed, 96 insertions(+), 10 deletions(-)

Index: src/gdb/infrun.c
===================================================================
--- src.orig/gdb/infrun.c	2009-01-23 15:10:03.000000000 +0000
+++ src/gdb/infrun.c	2009-01-23 15:45:29.000000000 +0000
@@ -4269,6 +4269,15 @@ Further execution is probably impossible
   if (target_has_stack && !stop_stack_dummy)
     set_current_sal_from_frame (get_current_frame (), 1);
 
+  /* Let the user/frontend see the threads as stopped.  */
+  do_cleanups (old_chain);
+
+  /* Look up the hook_stop and run it (CLI internally handles problem
+     of stop_command's pre-hook not existing).  */
+  if (stop_command)
+    catch_errors (hook_stop_stub, stop_command,
+		  "Error while running hook_stop:\n", RETURN_MASK_ALL);
+
   if (!target_has_stack)
     goto done;
 
@@ -4425,16 +4434,6 @@ done:
 	   Delete any breakpoint that is to be deleted at the next stop.  */
 	breakpoint_auto_delete (inferior_thread ()->stop_bpstat);
     }
-
-  /* Tell the frontend about the new thread states.  */
-  do_cleanups (old_chain);
-
-  /* Look up the hook_stop and run it (CLI internally handles problem
-     of stop_command's pre-hook not existing).  */
-  if (stop_command)
-    catch_errors (hook_stop_stub, stop_command,
-		  "Error while running hook_stop:\n", RETURN_MASK_ALL);
-
 }
 
 static int
Index: src/gdb/testsuite/gdb.base/hook-stop-frame.c
===================================================================
--- /dev/null	1970-01-01 00:00:00.000000000 +0000
+++ src/gdb/testsuite/gdb.base/hook-stop-frame.c	2009-01-23 15:10:13.000000000 +0000
@@ -0,0 +1,32 @@
+/* This testcase is part of GDB, the GNU debugger.
+
+   Copyright 2008 Free Software Foundation, Inc.
+
+   This program is free software; you can redistribute it and/or modify
+   it under the terms of the GNU General Public License as published by
+   the Free Software Foundation; either version 3 of the License, or
+   (at your option) any later version.
+
+   This program is distributed in the hope that it will be useful,
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+   GNU General Public License for more details.
+
+   You should have received a copy of the GNU General Public License
+   along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
+
+void
+func (void)
+{
+  int a;
+
+  a = 1; /* set breakpoint here */
+}
+
+int
+main (int argc, char **argv)
+{
+  func ();
+
+  return 0;
+}
Index: src/gdb/testsuite/gdb.base/hook-stop-frame.exp
===================================================================
--- /dev/null	1970-01-01 00:00:00.000000000 +0000
+++ src/gdb/testsuite/gdb.base/hook-stop-frame.exp	2009-01-23 15:10:13.000000000 +0000
@@ -0,0 +1,55 @@
+# Copyright 2008 Free Software Foundation, Inc.
+
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 3 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+
+set testfile "hook-stop-frame"
+set srcfile ${testfile}.c
+set binfile ${objdir}/${subdir}/${testfile}
+
+if { [prepare_for_testing ${testfile}.exp "${testfile}" "${testfile}.c" {debug nowarnings}] } {
+    return -1
+}
+
+gdb_exit
+gdb_start
+gdb_reinitialize_dir $srcdir/$subdir
+gdb_load ${binfile}
+
+if ![runto_main] then {
+    perror "Couldn't run to main"
+}
+
+set bp_location [gdb_get_line_number "set breakpoint here"]
+
+gdb_test "break func" \
+    "Breakpoint.*at.* file .*$srcfile.*\\." \
+    "breakpoint line number"
+
+set test "define hook-stop command"
+gdb_test_multiple "define hook-stop" "$test" {
+    -re "Type commands for definition of \"hook-stop\".\r\nEnd with a line saying just \"end\".\r\n>$" {
+	gdb_test "echo \"Hello.\"\nend" "" "$test"
+    }
+}
+
+set test "hook-stop runs before frame print"
+gdb_test_multiple "continue" "$test" {
+    -re "\"Hello\\.\"\r\nBreakpo.*func.*set breakpoint here.*${gdb_prompt} $" {
+	pass $test
+    }
+
+    -re "Breakpo.*func.*set breakpoint here.*\"Hello\\.\".*${gdb_prompt} $" {
+	fail $test
+    }
+}

Re: [commit] Fix for PR9664.

[Pedro Alves]

[-- Attachment #1: Type: text/plain, Size: 52 bytes --]

EWRONGYEARALREADY ... [checked-in]

-- 
Pedro Alves

[-- Attachment #2: years.diff --]
[-- Type: text/x-diff, Size: 1859 bytes --]

Index: ChangeLog
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/ChangeLog,v
retrieving revision 1.1791
diff -u -p -r1.1791 ChangeLog
--- ChangeLog	23 Jan 2009 15:47:03 -0000	1.1791
+++ ChangeLog	23 Jan 2009 16:00:20 -0000
@@ -1,5 +1,10 @@
 2009-01-23  Pedro Alves  <pedro@codesourcery.com>
 
+	* gdb.base/hook-stop-frame.c, gdb.base/hook-stop-frame.exp: Update
+	copyright years.
+
+2009-01-23  Pedro Alves  <pedro@codesourcery.com>
+
 	PR gdb/9664:
 	* gdb.base/hook-stop-frame.c, gdb.base/hook-stop-frame.exp: New.
 
Index: gdb.base/hook-stop-frame.c
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/hook-stop-frame.c,v
retrieving revision 1.1
diff -u -p -r1.1 hook-stop-frame.c
--- gdb.base/hook-stop-frame.c	23 Jan 2009 15:47:03 -0000	1.1
+++ gdb.base/hook-stop-frame.c	23 Jan 2009 16:00:20 -0000
@@ -1,6 +1,6 @@
 /* This testcase is part of GDB, the GNU debugger.
 
-   Copyright 2008 Free Software Foundation, Inc.
+   Copyright 2009 Free Software Foundation, Inc.
 
    This program is free software; you can redistribute it and/or modify
    it under the terms of the GNU General Public License as published by
Index: gdb.base/hook-stop-frame.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/hook-stop-frame.exp,v
retrieving revision 1.1
diff -u -p -r1.1 hook-stop-frame.exp
--- gdb.base/hook-stop-frame.exp	23 Jan 2009 15:47:03 -0000	1.1
+++ gdb.base/hook-stop-frame.exp	23 Jan 2009 16:00:20 -0000
@@ -1,4 +1,4 @@
-# Copyright 2008 Free Software Foundation, Inc.
+# Copyright 2009 Free Software Foundation, Inc.
 
 # This program is free software; you can redistribute it and/or modify
 # it under the terms of the GNU General Public License as published by