Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: gdb-patches@sourceware.org
Cc: Michael Snyder <msnyder@vmware.com>
Subject: Re: RFC: Do not call write_pc for "signal SIGINT"
Date: Tue, 20 Jan 2009 15:32:00 -0000	[thread overview]
Message-ID: <20090120153237.GA11920@caradoc.them.org> (raw)
In-Reply-To: <20081117215501.GA19975@caradoc.them.org>

On Mon, Nov 17, 2008 at 04:55:01PM -0500, Daniel Jacobowitz wrote:
> Here it is with a testcase.
> 
> To recap: there is a tricky bug in signal_command.  If any non-zero
> signal is specified, it performs a jump to the current address instead
> of just resuming there.  This causes any pending system call to be
> interrupted, in a way that leaves a kernel-internal value in the
> return value register.  If we just delete that code, and the FIXME
> that goes with it, the right thing happens: instead of "Unknown
> error 514", the system call returns EINTR and the loop continues.

> 2008-11-17  Daniel Jacobowitz  <dan@codesourcery.com>
> 
> 	PR gdb/2241
> 	* infcmd.c (signal_command): Do not specify a resume PC.
> 
> 2008-11-17  Daniel Jacobowitz  <dan@codesourcery.com>
> 
> 	PR gdb/2241
> 	* gdb.base/interrupt.c (sigint_handler): New.
> 	(main): Install a SIGINT handler if SIGNALS is defined.  Exit
> 	on error.
> 	* gdb.base/interrupt.exp: Define SIGNALS unless gdb,nosignals.
> 	Test "signal SIGINT".

I have checked this in.

-- 
Daniel Jacobowitz
CodeSourcery


      parent reply	other threads:[~2009-01-20 15:32 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-28 15:56 Daniel Jacobowitz
2008-08-28 18:13 ` Michael Snyder
2008-08-28 18:19   ` Daniel Jacobowitz
2008-08-28 18:38     ` Michael Snyder
2008-08-28 22:33       ` Daniel Jacobowitz
2008-11-18  4:18         ` Daniel Jacobowitz
2008-11-18  5:46           ` Pedro Alves
2009-01-20 15:32           ` Daniel Jacobowitz [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090120153237.GA11920@caradoc.them.org \
    --to=drow@false.org \
    --cc=gdb-patches@sourceware.org \
    --cc=msnyder@vmware.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox