From: Daniel Jacobowitz <drow@false.org>
To: gdb-patches@sourceware.org
Subject: Re: RFC: Do not call write_pc for "signal SIGINT"
Date: Thu, 28 Aug 2008 18:19:00 -0000 [thread overview]
Message-ID: <20080828181841.GA30866@caradoc.them.org> (raw)
In-Reply-To: <48B6E9F4.5080403@vmware.com>
On Thu, Aug 28, 2008 at 11:09:56AM -0700, Michael Snyder wrote:
> Hmmm, kind of opaque. Your new code seems like the right
> thing to do, but I don't understand the code that you're replacing.
>
> Isn't -1 supposed to mean the same as stop_pc?
Except that we call gdbarch_write_pc to replace the PC in this case,
and that has side effects - take a look at a Linux example.
> And isn't signal 0 equivalent to no signal?
Yes, that's right.
>> This isn't the only place where Linux's internal errno codes can leak
>> back into user programs because of how we fiddle orig_eax. I'll file
>> another bug report about that.
>
> Now you've really lost me. What have errno codes
> got to do with this?
Sorry, take a look at the PR (gdb/2241) for more information. When
you hit C-c during select, and then type "signal SIGINT", the program
gets errno 514 instead of EINTR.
Yes, I know, I need a testcase...
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2008-08-28 18:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-28 15:56 Daniel Jacobowitz
2008-08-28 18:13 ` Michael Snyder
2008-08-28 18:19 ` Daniel Jacobowitz [this message]
2008-08-28 18:38 ` Michael Snyder
2008-08-28 22:33 ` Daniel Jacobowitz
2008-11-18 4:18 ` Daniel Jacobowitz
2008-11-18 5:46 ` Pedro Alves
2009-01-20 15:32 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080828181841.GA30866@caradoc.them.org \
--to=drow@false.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox