From: "Ulrich Weigand" <uweigand@de.ibm.com>
To: brobecker@adacore.com (Joel Brobecker)
Cc: gdb-patches@sourceware.org
Subject: Re: [rfc] Add assert to catch get_frame_arch (NULL) calls
Date: Thu, 15 Jan 2009 15:41:00 -0000 [thread overview]
Message-ID: <200901151541.n0FFf4E1018058@d12av02.megacenter.de.ibm.com> (raw)
In-Reply-To: <20090115112010.GH24105@adacore.com> from "Joel Brobecker" at Jan 15, 2009 03:20:10 PM
Joel Brobecker wrote:
> > ChangeLog:
> >
> > * frame.c (get_frame_arch): Abort if called with NULL this_frame.
>
> This would fine for me. I'm slightly concerned about the next release,
> whether this might introduce an unnecessary risk or not. But this
> will depend on the amount of time that we will take before creating
> the next branch. I will add that to the list of things to reassess
> before we make the next release.
Agreed. I've checked this in for now; we can always decide to pull
it back out on the release branch, if necessary.
Bye,
Ulrich
--
Dr. Ulrich Weigand
GNU Toolchain for Linux on System z and Cell BE
Ulrich.Weigand@de.ibm.com
prev parent reply other threads:[~2009-01-15 15:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-13 18:07 Ulrich Weigand
2009-01-15 11:20 ` Joel Brobecker
2009-01-15 15:41 ` Ulrich Weigand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200901151541.n0FFf4E1018058@d12av02.megacenter.de.ibm.com \
--to=uweigand@de.ibm.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox