From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27203 invoked by alias); 15 Jan 2009 15:41:55 -0000 Received: (qmail 27139 invoked by uid 22791); 15 Jan 2009 15:41:55 -0000 X-SWARE-Spam-Status: No, hits=-1.4 required=5.0 tests=AWL,BAYES_00,MSGID_FROM_MTA_HEADER,SPF_SOFTFAIL X-Spam-Check-By: sourceware.org Received: from mtagate2.de.ibm.com (HELO mtagate2.de.ibm.com) (195.212.17.162) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 15 Jan 2009 15:41:08 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate2.de.ibm.com (8.13.1/8.13.1) with ESMTP id n0FFf5tq005260 for ; Thu, 15 Jan 2009 15:41:05 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v9.1) with ESMTP id n0FFf4tc4157464 for ; Thu, 15 Jan 2009 16:41:04 +0100 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n0FFf4FM018064 for ; Thu, 15 Jan 2009 16:41:04 +0100 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with SMTP id n0FFf4E1018058; Thu, 15 Jan 2009 16:41:04 +0100 Message-Id: <200901151541.n0FFf4E1018058@d12av02.megacenter.de.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Thu, 15 Jan 2009 16:41:04 +0100 Subject: Re: [rfc] Add assert to catch get_frame_arch (NULL) calls To: brobecker@adacore.com (Joel Brobecker) Date: Thu, 15 Jan 2009 15:41:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org In-Reply-To: <20090115112010.GH24105@adacore.com> from "Joel Brobecker" at Jan 15, 2009 03:20:10 PM MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-01/txt/msg00356.txt.bz2 Joel Brobecker wrote: > > ChangeLog: > > > > * frame.c (get_frame_arch): Abort if called with NULL this_frame. > > This would fine for me. I'm slightly concerned about the next release, > whether this might introduce an unnecessary risk or not. But this > will depend on the amount of time that we will take before creating > the next branch. I will add that to the list of things to reassess > before we make the next release. Agreed. I've checked this in for now; we can always decide to pull it back out on the release branch, if necessary. Bye, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com