Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
* [patch]: Fix build for w64 in ser-mingw.c
@ 2009-01-14 19:55 Kai Tietz
  2009-01-14 20:06 ` Pedro Alves
  0 siblings, 1 reply; 3+ messages in thread
From: Kai Tietz @ 2009-01-14 19:55 UTC (permalink / raw)
  To: gdb-patches

Hello,

while testing the gdb support for the new w64 I found a problem in
mingw-ser.c, which produced warnings about functions that aren't
returning, but have a return type specified.

ChangeLog

2009-01-14  Kai Tietz  <kai.tietz@onevision.com>

	* mingw-ser.c (console_select_thread): Add return to make
	compiler happy.
	(pipe_select_thread): Likewise.
	(file_select_thread): Likewise.

Tested on x86_64-pc-mingw32 and for i686-pc-cygwin

Ok for apply?

Cheers,
Kai

-- 
|  (\_/) This is Bunny. Copy and paste
| (='.'=) Bunny into your signature to help
| (")_(") him gain world domination

Index: src/gdb/ser-mingw.c
===================================================================
--- src.orig/gdb/ser-mingw.c
+++ src/gdb/ser-mingw.c
@@ -573,6 +573,7 @@ console_select_thread (void *arg)

       SetEvent(state->have_stopped);
     }
+  return 0;
 }

 static int
@@ -633,6 +634,7 @@ pipe_select_thread (void *arg)

       SetEvent (state->have_stopped);
     }
+  return 0;
 }

 static DWORD WINAPI
@@ -657,6 +659,7 @@ file_select_thread (void *arg)

       SetEvent (state->have_stopped);
     }
+  return 0;
 }

 static void


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [patch]: Fix build for w64 in ser-mingw.c
  2009-01-14 19:55 [patch]: Fix build for w64 in ser-mingw.c Kai Tietz
@ 2009-01-14 20:06 ` Pedro Alves
  2009-01-14 20:23   ` Kai Tietz
  0 siblings, 1 reply; 3+ messages in thread
From: Pedro Alves @ 2009-01-14 20:06 UTC (permalink / raw)
  To: gdb-patches; +Cc: Kai Tietz

On Wednesday 14 January 2009 19:54:39, Kai Tietz wrote:

> 2009-01-14  Kai Tietz  <kai.tietz@onevision.com>
> 
> 	* mingw-ser.c (console_select_thread): Add return to make
> 	compiler happy.
> 	(pipe_select_thread): Likewise.
> 	(file_select_thread): Likewise.
> 
> Tested on x86_64-pc-mingw32 and for i686-pc-cygwin
> 
> Ok for apply?
> 

Sure.  Thanks.

-- 
Pedro Alves


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [patch]: Fix build for w64 in ser-mingw.c
  2009-01-14 20:06 ` Pedro Alves
@ 2009-01-14 20:23   ` Kai Tietz
  0 siblings, 0 replies; 3+ messages in thread
From: Kai Tietz @ 2009-01-14 20:23 UTC (permalink / raw)
  To: Pedro Alves; +Cc: gdb-patches

2009/1/14 Pedro Alves <pedro@codesourcery.com>:
> On Wednesday 14 January 2009 19:54:39, Kai Tietz wrote:
>
>> 2009-01-14  Kai Tietz  <kai.tietz@onevision.com>
>>
>>       * mingw-ser.c (console_select_thread): Add return to make
>>       compiler happy.
>>       (pipe_select_thread): Likewise.
>>       (file_select_thread): Likewise.
>>
>> Tested on x86_64-pc-mingw32 and for i686-pc-cygwin
>>
>> Ok for apply?
>>
>
> Sure.  Thanks.

Committed.

Thanks,
Kai

-- 
|  (\_/) This is Bunny. Copy and paste
| (='.'=) Bunny into your signature to help
| (")_(") him gain world domination


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2009-01-14 20:23 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-01-14 19:55 [patch]: Fix build for w64 in ser-mingw.c Kai Tietz
2009-01-14 20:06 ` Pedro Alves
2009-01-14 20:23   ` Kai Tietz

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox