From: Christopher Faylor <cgf-use-the-mailinglist-please@sourceware.org>
To: gdb-patches@sourceware.org, Joel Brobecker <brobecker@adacore.com>
Subject: Re: [RFA/win32] Problem storing result of GetProcAddress
Date: Wed, 07 Jan 2009 17:04:00 -0000 [thread overview]
Message-ID: <20090107170347.GG31906@ednor.casa.cgf.cx> (raw)
In-Reply-To: <20090107114322.GD1751@adacore.com>
On Wed, Jan 07, 2009 at 03:43:22PM +0400, Joel Brobecker wrote:
>2009-01-07 Joel Brobecker <brobecker@adacore.com>
>
> * win32-nat.c (has_detach_ability, set_process_privilege):
> Cast the result of GetProcAddress to (void *) to avoid
> a compilation warning.
>
>Tested on x86-windows. Note that this depends on one of my previous
>patches that renames certain global variables:
>
> | * win32-nat.c (kernel32_DebugSetProcessKillOnExit): Renames
> | DebugSetProcessKillOnExit. Update all uses in this file.
> | (kernel32_DebugActiveProcessStop): Renames DebugActiveProcessStop.
> | Update all uses in this file.
>
>OK to apply?
Yes. I guess that means that the rename to prefix kernel32_ is approved
too but I'd appreciate it if you would universally add the kernel32_ prefix
to everything that is dynamically derived from kernel32.
cgf
next prev parent reply other threads:[~2009-01-07 17:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-07 11:43 Joel Brobecker
2009-01-07 17:04 ` Christopher Faylor [this message]
2009-01-09 10:49 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090107170347.GG31906@ednor.casa.cgf.cx \
--to=cgf-use-the-mailinglist-please@sourceware.org \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox