From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-60939-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 13098 invoked by alias); 7 Jan 2009 17:04:02 -0000
Received: (qmail 13040 invoked by uid 22791); 7 Jan 2009 17:04:01 -0000
X-Spam-Check-By: sourceware.org
Received: from pool-96-233-71-199.bstnma.fios.verizon.net (HELO cgf.cx) (96.233.71.199)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 07 Jan 2009 17:03:57 +0000
Received: from ednor.cgf.cx (ednor.casa.cgf.cx [192.168.187.5]) 	by cgf.cx (Postfix) with ESMTP id 93F5A13C028; 	Wed,  7 Jan 2009 12:03:47 -0500 (EST)
Received: by ednor.cgf.cx (Postfix, from userid 201) 	id 9760F2B35E; Wed,  7 Jan 2009 12:03:47 -0500 (EST)
Date: Wed, 07 Jan 2009 17:04:00 -0000
From: Christopher Faylor <cgf-use-the-mailinglist-please@sourceware.org>
To: gdb-patches@sourceware.org, Joel Brobecker <brobecker@adacore.com>
Subject: Re: [RFA/win32] Problem storing result of GetProcAddress
Message-ID: <20090107170347.GG31906@ednor.casa.cgf.cx>
Mail-Followup-To: gdb-patches@sourceware.org, 	Joel Brobecker <brobecker@adacore.com>
References: <20090107114322.GD1751@adacore.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20090107114322.GD1751@adacore.com>
User-Agent: Mutt/1.5.16 (2007-06-09)
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2009-01/txt/msg00109.txt.bz2

On Wed, Jan 07, 2009 at 03:43:22PM +0400, Joel Brobecker wrote:
>2009-01-07  Joel Brobecker  <brobecker@adacore.com>
>
>        * win32-nat.c (has_detach_ability, set_process_privilege):
>        Cast the result of GetProcAddress to (void *) to avoid
>        a compilation warning.
>
>Tested on x86-windows. Note that this depends on one of my previous
>patches that renames certain global variables:
>
>    | * win32-nat.c (kernel32_DebugSetProcessKillOnExit): Renames
>    | DebugSetProcessKillOnExit.  Update all uses in this file.
>    | (kernel32_DebugActiveProcessStop): Renames DebugActiveProcessStop.
>    | Update all uses in this file.
>
>OK to apply?

Yes.  I guess that means that the rename to prefix kernel32_ is approved
too but I'd appreciate it if you would universally add the kernel32_ prefix
to everything that is dynamically derived from kernel32.

cgf