Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA/win32] Change the DLL base address type to LPVOID
Date: Wed, 07 Jan 2009 14:43:00 -0000	[thread overview]
Message-ID: <20090107144259.GA31244@host0.dyn.jankratochvil.net> (raw)
In-Reply-To: <20090107114620.GE1751@adacore.com>

On Wed, 07 Jan 2009 12:46:20 +0100, Joel Brobecker wrote:
> 2009-01-07  Joel Brobecker  <brobecker@adacore.com>
> 
>         * win32-nat.c (get_module_name): Change the type of parameter
>         "base_address" to LPVOID.  Remove unnecessary cast.
>         (struct lm_info): Change type of load_addr to LPVOID.
>         (win32_make_so): Change the type of parameter "load_addr"
>         to LPVOID.  Remove some unnecessary casts.
>         (handle_unload_dll): Change the type of "lpBaseOfDll" to LPVOID.
>         (win32_xfer_shared_libraries): Add missing cast.
...

[ farproc.diff ]
> -	kernel32_DebugSetProcessKillOnExit = GetProcAddress (kernel32,
> -						 "DebugSetProcessKillOnExit");
> +	kernel32_DebugSetProcessKillOnExit =
> +	  (void *) GetProcAddress (kernel32, "DebugSetProcessKillOnExit");

You have attached a different patch file, the LPVOID patch file is missing.


Regards,
Jan


  reply	other threads:[~2009-01-07 14:43 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-07 11:46 Joel Brobecker
2009-01-07 14:43 ` Jan Kratochvil [this message]
2009-01-07 17:04 ` Christopher Faylor
2009-01-09 10:55   ` Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090107144259.GA31244@host0.dyn.jankratochvil.net \
    --to=jan.kratochvil@redhat.com \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox