From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5773 invoked by alias); 7 Jan 2009 14:43:21 -0000 Received: (qmail 5681 invoked by uid 22791); 7 Jan 2009 14:43:20 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,J_CHICKENPOX_74,KAM_MX,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx2.redhat.com (HELO mx2.redhat.com) (66.187.237.31) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 07 Jan 2009 14:43:12 +0000 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n07Eh8DX004422; Wed, 7 Jan 2009 09:43:09 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n07Eh8tR000399; Wed, 7 Jan 2009 09:43:09 -0500 Received: from host0.dyn.jankratochvil.net (sebastian-int.corp.redhat.com [172.16.52.221]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n07Eh7x4017520; Wed, 7 Jan 2009 09:43:08 -0500 Received: from host0.dyn.jankratochvil.net (localhost [127.0.0.1]) by host0.dyn.jankratochvil.net (8.14.3/8.14.3) with ESMTP id n07Eh3kJ032515; Wed, 7 Jan 2009 15:43:04 +0100 Received: (from jkratoch@localhost) by host0.dyn.jankratochvil.net (8.14.3/8.14.2/Submit) id n07EgxeF032498; Wed, 7 Jan 2009 15:42:59 +0100 Date: Wed, 07 Jan 2009 14:43:00 -0000 From: Jan Kratochvil To: Joel Brobecker Cc: gdb-patches@sourceware.org Subject: Re: [RFA/win32] Change the DLL base address type to LPVOID Message-ID: <20090107144259.GA31244@host0.dyn.jankratochvil.net> References: <20090107114620.GE1751@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090107114620.GE1751@adacore.com> User-Agent: Mutt/1.5.18 (2008-05-17) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-01/txt/msg00097.txt.bz2 On Wed, 07 Jan 2009 12:46:20 +0100, Joel Brobecker wrote: > 2009-01-07 Joel Brobecker > > * win32-nat.c (get_module_name): Change the type of parameter > "base_address" to LPVOID. Remove unnecessary cast. > (struct lm_info): Change type of load_addr to LPVOID. > (win32_make_so): Change the type of parameter "load_addr" > to LPVOID. Remove some unnecessary casts. > (handle_unload_dll): Change the type of "lpBaseOfDll" to LPVOID. > (win32_xfer_shared_libraries): Add missing cast. ... [ farproc.diff ] > - kernel32_DebugSetProcessKillOnExit = GetProcAddress (kernel32, > - "DebugSetProcessKillOnExit"); > + kernel32_DebugSetProcessKillOnExit = > + (void *) GetProcAddress (kernel32, "DebugSetProcessKillOnExit"); You have attached a different patch file, the LPVOID patch file is missing. Regards, Jan