[RFA/win32] CONTEXT_EXTENDED_REGISTERS is not defined on x86_64-windows

[RFA/win32] CONTEXT_EXTENDED_REGISTERS is not defined on x86_64-windows

[Joel Brobecker]

[-- Attachment #1: Type: text/plain, Size: 674 bytes --]

Hello,

win32-nat.c uses CONTEXT_EXTENDED_REGISTERS in the following macro
declaration:

 #define CONTEXT_DEBUGGER_DR CONTEXT_DEBUGGER | CONTEXT_DEBUG_REGISTERS \
        | CONTEXT_EXTENDED_REGISTERS

However, CONTEXT_EXTENDED_REGISTERS is not defined on x86_64-windows.
It seems to me that this macro only makes sense on i386, so I simply
defined it to 0 if not already defined. This should have no effect
on x86-windows while doing the right thing on x86_64-windows.

2009-01-07  Joel Brobecker  <brobecker@adacore.com>

        * win32-nat.c (CONTEXT_EXTENDED_REGISTERS): Define to 0 if not
        already defined.

Tested on x86-windows.
OK to apply?

Thanks,
-- 
Joel

[-- Attachment #2: macro.diff --]
[-- Type: text/plain, Size: 496 bytes --]

diff --git a/gdb/win32-nat.c b/gdb/win32-nat.c
index 51443a3..1b15dfb 100644
--- a/gdb/win32-nat.c
+++ b/gdb/win32-nat.c
@@ -85,6 +85,12 @@ enum
 #endif
 #include <psapi.h>
 
+#ifndef CONTEXT_EXTENDED_REGISTERS
+/* This macro is only defined on ia32.  It only makes sense on this target,
+   so define it as zero if not already defined.  */
+#define CONTEXT_EXTENDED_REGISTERS 0
+#endif
+
 #define CONTEXT_DEBUGGER_DR CONTEXT_DEBUGGER | CONTEXT_DEBUG_REGISTERS \
 	| CONTEXT_EXTENDED_REGISTERS
 

Re: [RFA/win32] CONTEXT_EXTENDED_REGISTERS is not defined on x86_64-windows

[Christopher Faylor]

On Wed, Jan 07, 2009 at 03:34:52PM +0400, Joel Brobecker wrote:
>2009-01-07  Joel Brobecker  <brobecker@adacore.com>
>
>        * win32-nat.c (CONTEXT_EXTENDED_REGISTERS): Define to 0 if not
>        already defined.
>
>Tested on x86-windows.
>OK to apply?

Yes.

cgf

Re: [RFA/win32] CONTEXT_EXTENDED_REGISTERS is not defined on x86_64-windows

[Joel Brobecker]

> >2009-01-07  Joel Brobecker  <brobecker@adacore.com>
> >
> >        * win32-nat.c (CONTEXT_EXTENDED_REGISTERS): Define to 0 if not
> >        already defined.
> >
> >Tested on x86-windows.
> >OK to apply?
> 
> Yes.

Thank you. Checked in.

-- 
Joel