RFA: fix PR 8307

RFA: fix PR 8307

[Tom Tromey]

PR 8307 is about a small memory leak in environ.c.

This is just the patch from the PR.

Built and regtested on x86-64 (compile farm).
Also I ran it under valgrind, before and after, to verify.

Please review.

Tom

2008-12-22  Adam Denton  <adenton@yahoo.com>

	PR gdb/8307:
	* environ.c (free_environ): Free e->vector.

diff --git a/gdb/environ.c b/gdb/environ.c
index ee471ad..cd40193 100644
--- a/gdb/environ.c
+++ b/gdb/environ.c
@@ -49,6 +49,7 @@ free_environ (struct gdb_environ *e)
   while (*vector)
     xfree (*vector++);
 
+  xfree (e->vector);
   xfree (e);
 }
 

Re: RFA: fix PR 8307

[Joel Brobecker]

> 2008-12-22  Adam Denton  <adenton@yahoo.com>
> 
> 	PR gdb/8307:
> 	* environ.c (free_environ): Free e->vector.

This is to cover the terminating NULL in the gdb_environ vector.
Looks good to me; and thanks for taking care of these PRs.

-- 
Joel

Re: RFA: fix PR 8307

[Tom Tromey]

>>>>> "Joel" == Joel Brobecker <brobecker@adacore.com> writes:

>> 2008-12-22  Adam Denton  <adenton@yahoo.com>
>> 
>> PR gdb/8307:
>> * environ.c (free_environ): Free e->vector.

Joel> This is to cover the terminating NULL in the gdb_environ vector.
Joel> Looks good to me; and thanks for taking care of these PRs.

Committed.

Tom