From: Joel Brobecker <brobecker@adacore.com>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: RFA: fix pretty-printing in "bt full"
Date: Mon, 22 Dec 2008 05:01:00 -0000 [thread overview]
Message-ID: <20081222050024.GD25416@adacore.com> (raw)
In-Reply-To: <m3myexxjv2.fsf@fleche.redhat.com>
> I think this looks nicer, because the contents of "a" are indented
> underneath "a".
I agree.
> 2008-12-15 Tom Tromey <tromey@redhat.com>
>
> * stack.c (print_block_frame_locals): Print spaces, not tabs.
> Pass indentation level to print_variable_value.
> (print_frame_arg_vars): Update.
> * value.h (print_variable_value): Update.
> * printcmd.c (print_variable_value): Add 'indent' argument. Use
> common_val_print.
> * f-valprint.c (info_common_command): Update.
Just one comment: How about letting print_variable_value do all
the indenting instead of having the caller indent the first line?
I think that would simplify the usage as well as the description.
What do you think?
The rest looks OK to me.
Thanks,
--
Joel
next prev parent reply other threads:[~2008-12-22 5:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-15 20:30 Tom Tromey
2008-12-22 5:01 ` Joel Brobecker [this message]
2008-12-22 14:18 ` Tom Tromey
2008-12-22 20:52 ` Joel Brobecker
2008-12-22 23:17 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081222050024.GD25416@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox