From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20655 invoked by alias); 22 Dec 2008 05:01:10 -0000 Received: (qmail 20581 invoked by uid 22791); 22 Dec 2008 05:01:08 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 22 Dec 2008 05:00:33 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id E95602A9615; Mon, 22 Dec 2008 00:00:31 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id FBcEruM8YzEW; Mon, 22 Dec 2008 00:00:31 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 6BD022A9611; Mon, 22 Dec 2008 00:00:31 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 15185E7ACD; Mon, 22 Dec 2008 09:00:24 +0400 (RET) Date: Mon, 22 Dec 2008 05:01:00 -0000 From: Joel Brobecker To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: RFA: fix pretty-printing in "bt full" Message-ID: <20081222050024.GD25416@adacore.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.2i Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-12/txt/msg00372.txt.bz2 > I think this looks nicer, because the contents of "a" are indented > underneath "a". I agree. > 2008-12-15 Tom Tromey > > * stack.c (print_block_frame_locals): Print spaces, not tabs. > Pass indentation level to print_variable_value. > (print_frame_arg_vars): Update. > * value.h (print_variable_value): Update. > * printcmd.c (print_variable_value): Add 'indent' argument. Use > common_val_print. > * f-valprint.c (info_common_command): Update. Just one comment: How about letting print_variable_value do all the indenting instead of having the caller indent the first line? I think that would simplify the usage as well as the description. What do you think? The rest looks OK to me. Thanks, -- Joel