Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Daniel Jacobowitz <drow@false.org>
Cc: Ulrich Weigand <uweigand@de.ibm.com>, gdb-patches@sourceware.org
Subject: Re: [patch] Fix hw watchpoints regression on i386/x86_64/ia64
Date: Sun, 21 Dec 2008 19:04:00 -0000	[thread overview]
Message-ID: <20081221190318.GB27604@host0.dyn.jankratochvil.net> (raw)
In-Reply-To: <20081221153646.GA10881@caradoc.them.org>

On Sun, 21 Dec 2008 16:36:46 +0100, Daniel Jacobowitz wrote:
> On Sun, Dec 21, 2008 at 04:10:46PM +0100, Jan Kratochvil wrote:
> > > This test case should respect [target_info exists gdb,no_hardware_watchpoints].
> >                        ^<-also
> > as according to my test on ppc64 RHEL-4 gdb-6.3+kernel (both not supporting
> > ppc hw watchpoints) dejagnu-1.4.4 did not have `no_hardware_watchpoints' set.
> 
> I suggest you use a custom board file which does set it.

Sorry I did commit it this way.  Should I commit this one?


Regards,
Jan


2008-12-21  Jan Kratochvil  <jan.kratochvil@redhat.com>

	* gdb.base/watchpoint-hw.exp: Remove the limitation on specific arches.

--- gdb/testsuite/gdb.base/watchpoint-hw.exp	21 Dec 2008 15:01:32 -0000	1.1
+++ gdb/testsuite/gdb.base/watchpoint-hw.exp	21 Dec 2008 18:59:55 -0000
@@ -13,10 +13,7 @@
 # You should have received a copy of the GNU General Public License
 # along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
-# Arch not supporting hw watchpoints does not imply no_hardware_watchpoints set.
-if {(![istarget "i?86-*-*"] && ![istarget "x86_64-*-*"]
-     && ![istarget "ia64-*-*"] && ![istarget "s390*-*-*"])
-    || [target_info exists gdb,no_hardware_watchpoints]} then {
+if {[target_info exists gdb,no_hardware_watchpoints]} then {
     verbose "Skipping watchpoint-hw test."
     return
 }


  reply	other threads:[~2008-12-21 19:04 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-07 22:38 Jan Kratochvil
2008-12-08  8:39 ` Jan Kratochvil
2008-12-17 20:13   ` Ulrich Weigand
2008-12-21 15:12     ` Jan Kratochvil
2008-12-21 15:37       ` Daniel Jacobowitz
2008-12-21 19:04         ` Jan Kratochvil [this message]
2008-12-21 16:16       ` Andreas Schwab
2008-12-21 17:12         ` [ob] Remove bug-gdb@prep.ai.mit.edu (PR 8648) [Re: [patch] Fix hw watchpoints regression on i386/x86_64/ia64] Jan Kratochvil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081221190318.GB27604@host0.dyn.jankratochvil.net \
    --to=jan.kratochvil@redhat.com \
    --cc=drow@false.org \
    --cc=gdb-patches@sourceware.org \
    --cc=uweigand@de.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox