From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 554 invoked by alias); 21 Dec 2008 19:04:40 -0000 Received: (qmail 545 invoked by uid 22791); 21 Dec 2008 19:04:39 -0000 X-SWARE-Spam-Status: No, hits=-2.2 required=5.0 tests=AWL,BAYES_00,KAM_MX,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx2.redhat.com (HELO mx2.redhat.com) (66.187.237.31) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 21 Dec 2008 19:03:42 +0000 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id mBLJ3ce6012595; Sun, 21 Dec 2008 14:03:38 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id mBLJ3bvG016379; Sun, 21 Dec 2008 14:03:37 -0500 Received: from host0.dyn.jankratochvil.net (sebastian-int.corp.redhat.com [172.16.52.221]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id mBLJ3ZpS012354; Sun, 21 Dec 2008 14:03:36 -0500 Received: from host0.dyn.jankratochvil.net (localhost [127.0.0.1]) by host0.dyn.jankratochvil.net (8.14.3/8.14.3) with ESMTP id mBLJ3RnI017029; Sun, 21 Dec 2008 20:03:28 +0100 Received: (from jkratoch@localhost) by host0.dyn.jankratochvil.net (8.14.3/8.14.2/Submit) id mBLJ3OUO016812; Sun, 21 Dec 2008 20:03:24 +0100 Date: Sun, 21 Dec 2008 19:04:00 -0000 From: Jan Kratochvil To: Daniel Jacobowitz Cc: Ulrich Weigand , gdb-patches@sourceware.org Subject: Re: [patch] Fix hw watchpoints regression on i386/x86_64/ia64 Message-ID: <20081221190318.GB27604@host0.dyn.jankratochvil.net> References: <20081208083759.GA18359@host0.dyn.jankratochvil.net> <200812172012.mBHKCDY5006031@d12av02.megacenter.de.ibm.com> <20081221151046.GA9181@host0.dyn.jankratochvil.net> <20081221153646.GA10881@caradoc.them.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20081221153646.GA10881@caradoc.them.org> User-Agent: Mutt/1.5.18 (2008-05-17) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-12/txt/msg00368.txt.bz2 On Sun, 21 Dec 2008 16:36:46 +0100, Daniel Jacobowitz wrote: > On Sun, Dec 21, 2008 at 04:10:46PM +0100, Jan Kratochvil wrote: > > > This test case should respect [target_info exists gdb,no_hardware_watchpoints]. > > ^<-also > > as according to my test on ppc64 RHEL-4 gdb-6.3+kernel (both not supporting > > ppc hw watchpoints) dejagnu-1.4.4 did not have `no_hardware_watchpoints' set. > > I suggest you use a custom board file which does set it. Sorry I did commit it this way. Should I commit this one? Regards, Jan 2008-12-21 Jan Kratochvil * gdb.base/watchpoint-hw.exp: Remove the limitation on specific arches. --- gdb/testsuite/gdb.base/watchpoint-hw.exp 21 Dec 2008 15:01:32 -0000 1.1 +++ gdb/testsuite/gdb.base/watchpoint-hw.exp 21 Dec 2008 18:59:55 -0000 @@ -13,10 +13,7 @@ # You should have received a copy of the GNU General Public License # along with this program. If not, see . -# Arch not supporting hw watchpoints does not imply no_hardware_watchpoints set. -if {(![istarget "i?86-*-*"] && ![istarget "x86_64-*-*"] - && ![istarget "ia64-*-*"] && ![istarget "s390*-*-*"]) - || [target_info exists gdb,no_hardware_watchpoints]} then { +if {[target_info exists gdb,no_hardware_watchpoints]} then { verbose "Skipping watchpoint-hw test." return }