From: Daniel Jacobowitz <drow@false.org>
To: Denis PILAT <denis.pilat@st.com>
Cc: Doug Evans <dje@google.com>, Michael Snyder <msnyder@vmware.com>,
Jon Beniston <jon@beniston.com>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: Patch to support spaces in filenames & paths
Date: Wed, 10 Dec 2008 16:20:00 -0000 [thread overview]
Message-ID: <20081210161909.GA10562@caradoc.them.org> (raw)
In-Reply-To: <493FE0E4.7080105@st.com>
On Wed, Dec 10, 2008 at 04:31:48PM +0100, Denis PILAT wrote:
> I made some experiments with parse_to_comma_and_eval, but I think I must
> be sure to understand what you need before going further in my
> implementation, and summarize the situation
parse_to_comma_and_eval is only required for functions that take more
than one expression. This doesn't, so it doesn't apply.
I see that buildargv is going to be a problem if the last argument is
a free-form expression. I'm not entirely sure what to do about that.
Maybe a GDB-local version that extracts one argument string at a time
and returns that, plus a pointer to the next unparsed bit of the
command line.
The important thing, in my opinion, is to use the same handling of
quotes and spaces that buildargv does for consistency with other
commands, like "file".
Maybe we can solve this later and just use buildargv. Compare with
add_symbol_file_command which takes an address.
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2008-12-10 16:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-02 13:09 Jon Beniston
2008-12-02 21:20 ` Michael Snyder
2008-12-02 23:38 ` Daniel Jacobowitz
2008-12-03 0:04 ` Pedro Alves
2008-12-03 0:26 ` Doug Evans
2008-12-04 9:38 ` Denis PILAT
2008-12-04 13:11 ` Daniel Jacobowitz
2008-12-10 15:32 ` Denis PILAT
2008-12-10 16:20 ` Daniel Jacobowitz [this message]
2009-01-05 14:20 ` Denis PILAT
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081210161909.GA10562@caradoc.them.org \
--to=drow@false.org \
--cc=denis.pilat@st.com \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=jon@beniston.com \
--cc=msnyder@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox