From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26770 invoked by alias); 10 Dec 2008 16:20:09 -0000 Received: (qmail 26761 invoked by uid 22791); 10 Dec 2008 16:20:08 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 10 Dec 2008 16:19:13 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 29FFE10E77; Wed, 10 Dec 2008 16:19:11 +0000 (GMT) Received: from caradoc.them.org (209.195.188.212.nauticom.net [209.195.188.212]) by nan.false.org (Postfix) with ESMTP id C1B7D10AD0; Wed, 10 Dec 2008 16:19:10 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1LARmH-00030z-Gp; Wed, 10 Dec 2008 11:19:09 -0500 Date: Wed, 10 Dec 2008 16:20:00 -0000 From: Daniel Jacobowitz To: Denis PILAT Cc: Doug Evans , Michael Snyder , Jon Beniston , "gdb-patches@sourceware.org" Subject: Re: Patch to support spaces in filenames & paths Message-ID: <20081210161909.GA10562@caradoc.them.org> Mail-Followup-To: Denis PILAT , Doug Evans , Michael Snyder , Jon Beniston , "gdb-patches@sourceware.org" References: <7D653316E38B4305941199D722BF20B0@bibi> <4935A5E2.5050503@vmware.com> <20081202233738.GA15530@caradoc.them.org> <4937A4E3.4040609@st.com> <20081204131028.GA24868@caradoc.them.org> <493FE0E4.7080105@st.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <493FE0E4.7080105@st.com> User-Agent: Mutt/1.5.17 (2008-05-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-12/txt/msg00189.txt.bz2 On Wed, Dec 10, 2008 at 04:31:48PM +0100, Denis PILAT wrote: > I made some experiments with parse_to_comma_and_eval, but I think I must > be sure to understand what you need before going further in my > implementation, and summarize the situation parse_to_comma_and_eval is only required for functions that take more than one expression. This doesn't, so it doesn't apply. I see that buildargv is going to be a problem if the last argument is a free-form expression. I'm not entirely sure what to do about that. Maybe a GDB-local version that extracts one argument string at a time and returns that, plus a pointer to the next unparsed bit of the command line. The important thing, in my opinion, is to use the same handling of quotes and spaces that buildargv does for consistency with other commands, like "file". Maybe we can solve this later and just use buildargv. Compare with add_symbol_file_command which takes an address. -- Daniel Jacobowitz CodeSourcery