Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Jerome Guitton <guitton@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA/Ada] remove ref to fields and ref to slices
Date: Tue, 09 Dec 2008 10:55:00 -0000	[thread overview]
Message-ID: <20081209105430.GN3823@adacore.com> (raw)
In-Reply-To: <20081209100418.GI52346@adacore.com>

> Not really. ada_value_slice already exists: same function, but it works
> on array. ada_value_slice_ptr, at the contrary, works on pointers to
> array or references. Maybe ada_value_slice_from_ptr would be clearer?

Rats! I'm looking at the code, and I am thinking that there is a bit
of simplification that we could look at, now that the contents of lazy
values is allocated later. For instance:

ada_coerce_to_simple_array_ptr vs ada_coerce_to_simple_array

If we got rid of ada_coerce_to_simple_array_ptr, then we probably
wouldn't need ada_value_slice_ptr..

But in the meantime, I do think that ada_value_slice_from_ptr is
clearer.

Thanks,
-- 
Joel


  reply	other threads:[~2008-12-09 10:55 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20081127100443.GA64300@adacore.com>
2008-12-08 23:31 ` Joel Brobecker
2008-12-09 10:04   ` Jerome Guitton
2008-12-09 10:55     ` Joel Brobecker [this message]
2008-12-12 15:29       ` Jerome Guitton
2008-12-12 17:26         ` Joel Brobecker
2008-12-15 10:42           ` Jerome Guitton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081209105430.GN3823@adacore.com \
    --to=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=guitton@adacore.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox