Re: [RFA/Ada] remove ref to fields and ref to slices

[Joel Brobecker <brobecker@adacore.com>]

> 2008-11-27  Jerome Guitton  <guitton@adacore.com>
> 
> 	* ada-lang.c (ada_value_slice_ptr): Return a lazy value instead
> 	of a reference. Update comment.
> 	(ada_value_struct_elt): Ditto if arg is a pointer or a reference.
> 	Update comment as well.

OK, but a couple of comments:

>  static struct value *
>  ada_value_slice_ptr (struct value *array_ptr, struct type *type,
>                       int low, int high)

Could you rename this function to "ada_value_slice"? Since we no longer
return a pointer to the slice but the slice itself, the _ptr suffix
could be confusing.

> @@ -6178,9 +6178,7 @@ ada_index_struct_field_1 (int *index_p, 
>  /* Given ARG, a value of type (pointer or reference to a)*
>     structure/union, extract the component named NAME from the ultimate
>     target structure/union and return it as a value with its
> -   appropriate type.  If ARG is a pointer or reference and the field
> -   is not packed, returns a reference to the field, otherwise the
> -   value of the field (an lvalue if ARG is an lvalue).     
> +   appropriate type.  Return the value of the field.

The last sentence you added seems redundant with the one before it
(that you adjusted).

-- 
Joel