From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org
Cc: "Ulrich Weigand" <uweigand@de.ibm.com>
Subject: Re: [rfc] [2/7] infrun cleanup: miscellaneous cleanups
Date: Sun, 07 Dec 2008 17:19:00 -0000 [thread overview]
Message-ID: <200812071719.24947.pedro@codesourcery.com> (raw)
In-Reply-To: <200812070123.40787.pedro@codesourcery.com>
On Sunday 07 December 2008 01:23:40, Pedro Alves wrote:
> On Sunday 07 December 2008 00:17:36, Ulrich Weigand wrote:
> > if (!ecs->wait_some_more)
> > {
> > - struct inferior *inf = find_inferior_pid (ptid_get_pid (ecs->ptid));
> > +
> Please change this bit to:
>
> - struct inferior *inf = find_inferior_pid (ptid_get_pid (ecs->ptid));
> + struct inferior *inf = find_inferior_pid (ptid_get_pid (inferior_ptid));
Looking again, it would be more correct (and safest as it doesn't change current
behaviour) to leave it as ptid_get_pid(ecs->ptid) in this patch, and change it
to ptid_get_pid (ptid) in the last patch (the event ptid).
--
Pedro Alves
next prev parent reply other threads:[~2008-12-07 17:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-07 0:18 Ulrich Weigand
2008-12-07 1:24 ` Pedro Alves
2008-12-07 17:19 ` Pedro Alves [this message]
2008-12-07 18:23 ` Ulrich Weigand
2008-12-07 19:04 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200812071719.24947.pedro@codesourcery.com \
--to=pedro@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=uweigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox