From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-60485-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 302 invoked by alias); 7 Dec 2008 17:19:55 -0000
Received: (qmail 32677 invoked by uid 22791); 7 Dec 2008 17:19:55 -0000
X-Spam-Check-By: sourceware.org
Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 07 Dec 2008 17:19:19 +0000
Received: (qmail 14695 invoked from network); 7 Dec 2008 17:19:18 -0000
Received: from unknown (HELO orlando.local) (pedro@127.0.0.2)   by mail.codesourcery.com with ESMTPA; 7 Dec 2008 17:19:18 -0000
From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org
Subject: Re: [rfc] [2/7] infrun cleanup: miscellaneous cleanups
Date: Sun, 07 Dec 2008 17:19:00 -0000
User-Agent: KMail/1.9.10
Cc: "Ulrich Weigand" <uweigand@de.ibm.com>
References: <200812070017.mB70HagV018378@d12av02.megacenter.de.ibm.com> <200812070123.40787.pedro@codesourcery.com>
In-Reply-To: <200812070123.40787.pedro@codesourcery.com>
MIME-Version: 1.0
Content-Type: text/plain;   charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
Message-Id: <200812071719.24947.pedro@codesourcery.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2008-12/txt/msg00131.txt.bz2

On Sunday 07 December 2008 01:23:40, Pedro Alves wrote:
> On Sunday 07 December 2008 00:17:36, Ulrich Weigand wrote:
> >    if (!ecs->wait_some_more)
> >      {
> > -      struct inferior *inf =3D find_inferior_pid (ptid_get_pid (ecs->p=
tid));
> > +=20=20=20=20=20=20
> Please change this bit to:
>=20
> - =A0 =A0 =A0struct inferior *inf =3D find_inferior_pid (ptid_get_pid (ec=
s->ptid));
> + =A0 =A0 =A0struct inferior *inf =3D find_inferior_pid (ptid_get_pid (in=
ferior_ptid));

Looking again, it would be more correct (and safest as it doesn't change cu=
rrent
behaviour) to leave it as ptid_get_pid(ecs->ptid) in this patch, and change=
 it
to ptid_get_pid (ptid) in the last patch (the event ptid).

--=20
Pedro Alves