Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Ulrich Weigand" <uweigand@de.ibm.com>
To: pedro@codesourcery.com (Pedro Alves)
Cc: gdb-patches@sourceware.org
Subject: Re: Set the stepping range from the function@PC, not@stop_pc.
Date: Fri, 05 Dec 2008 20:31:00 -0000	[thread overview]
Message-ID: <200812052030.mB5KUcjR012062@d12av02.megacenter.de.ibm.com> (raw)
In-Reply-To: <200812051946.06793.pedro@codesourcery.com> from "Pedro Alves" at Dec 05, 2008 07:46:06 PM

Pedro Alves wrote:

> Following up on:
>  http://sourceware.org/ml/gdb-patches/2008-12/msg00100.html
> 
> Here goes.  This addresses this valid use case:
> 
> < stopped at 0x1234, thread 1, (stop_pc == 0x1234) >
>  (gdb) set $pc = 0xf00
>  (gdb) step
> 
> GDB at this point would set the stepping range based on the
> function at 0x1234, but execution was about to resume at 0xf00.
> 
> GDB should instead be setting the stepping range from the
> function at 0xf00.

Thanks!

> I think it's obvious after the discussion, but I'd still like to
> have your approval.  OK?  Any objections?

It might be better to use get_frame_pc (frame) instead of read_pc (),
as we already set up the step_frame_id relative to that frame.  But
this is just a minor preference ...

Otherwise, this looks good to me.

Bye,
Ulrich

-- 
  Dr. Ulrich Weigand
  GNU Toolchain for Linux on System z and Cell BE
  Ulrich.Weigand@de.ibm.com


  reply	other threads:[~2008-12-05 20:31 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-05 19:47 Set the stepping range from the function at PC, not at stop_pc Pedro Alves
2008-12-05 20:31 ` Ulrich Weigand [this message]
2008-12-05 20:44   ` Set the stepping range from the function@PC, not@stop_pc Daniel Jacobowitz
2008-12-05 22:43     ` Pedro Alves
2008-12-05 23:37       ` Pedro Alves
2008-12-10 21:27         ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200812052030.mB5KUcjR012062@d12av02.megacenter.de.ibm.com \
    --to=uweigand@de.ibm.com \
    --cc=gdb-patches@sourceware.org \
    --cc=pedro@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox