From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20603 invoked by alias); 5 Dec 2008 20:31:31 -0000 Received: (qmail 20593 invoked by uid 22791); 5 Dec 2008 20:31:31 -0000 X-Spam-Check-By: sourceware.org Received: from mtagate3.de.ibm.com (HELO mtagate3.de.ibm.com) (195.212.29.152) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 05 Dec 2008 20:30:41 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate3.de.ibm.com (8.13.8/8.13.8) with ESMTP id mB5KUcmt206498 for ; Fri, 5 Dec 2008 20:30:38 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v9.1) with ESMTP id mB5KUcAh4018370 for ; Fri, 5 Dec 2008 21:30:38 +0100 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id mB5KUcs3012065 for ; Fri, 5 Dec 2008 21:30:38 +0100 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with SMTP id mB5KUcjR012062; Fri, 5 Dec 2008 21:30:38 +0100 Message-Id: <200812052030.mB5KUcjR012062@d12av02.megacenter.de.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Fri, 5 Dec 2008 21:30:38 +0100 Subject: Re: Set the stepping range from the function@PC, not@stop_pc. To: pedro@codesourcery.com (Pedro Alves) Date: Fri, 05 Dec 2008 20:31:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org In-Reply-To: <200812051946.06793.pedro@codesourcery.com> from "Pedro Alves" at Dec 05, 2008 07:46:06 PM MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-12/txt/msg00103.txt.bz2 Pedro Alves wrote: > Following up on: > http://sourceware.org/ml/gdb-patches/2008-12/msg00100.html > > Here goes. This addresses this valid use case: > > < stopped at 0x1234, thread 1, (stop_pc == 0x1234) > > (gdb) set $pc = 0xf00 > (gdb) step > > GDB at this point would set the stepping range based on the > function at 0x1234, but execution was about to resume at 0xf00. > > GDB should instead be setting the stepping range from the > function at 0xf00. Thanks! > I think it's obvious after the discussion, but I'd still like to > have your approval. OK? Any objections? It might be better to use get_frame_pc (frame) instead of read_pc (), as we already set up the step_frame_id relative to that frame. But this is just a minor preference ... Otherwise, this looks good to me. Bye, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com