From: Daniel Jacobowitz <drow@false.org>
To: Doug Evans <dje@google.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA] change gdbserver's pids to int
Date: Thu, 04 Dec 2008 13:16:00 -0000 [thread overview]
Message-ID: <20081204131535.GC24868@caradoc.them.org> (raw)
In-Reply-To: <20081204012417.1413E1C7A0F@localhost>
On Wed, Dec 03, 2008 at 05:24:16PM -0800, Doug Evans wrote:
> gdb uses an int for a pid (see ptid.pid in defs.h),
> and, for example, gdbserver's target_ops.create_inferior returns an int.
> For consistency I made pid an int elsewhere in gdbserver,
> except for "id" in struct inferior_list - it's used for more than just pids
> although I suspect int could be used here too, left for another day.
>
> Plus this cleans things up by removing local decls of signal_pid.
>
> Ok to check in?
Are you sure that every place you touched gets a system PID, not a
thread ID? They used to be ints, but were changed to unsigned long
because NPTL's TIDs do not fit in an int.
Also, do Windows PIDs fit in an int? Win32 pids must, but I expect
we'll get a Win64 port at some point.
I'd like to know the advantage before moving all the deck chairs round
again.
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2008-12-04 13:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-04 1:24 Doug Evans
2008-12-04 13:16 ` Daniel Jacobowitz [this message]
2008-12-04 23:02 ` Doug Evans
2008-12-04 23:30 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081204131535.GC24868@caradoc.them.org \
--to=drow@false.org \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox