From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12990 invoked by alias); 4 Dec 2008 13:16:17 -0000 Received: (qmail 12967 invoked by uid 22791); 4 Dec 2008 13:16:16 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 04 Dec 2008 13:15:37 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id A960910D5F; Thu, 4 Dec 2008 13:15:35 +0000 (GMT) Received: from caradoc.them.org (209.195.188.212.nauticom.net [209.195.188.212]) by nan.false.org (Postfix) with ESMTP id 9A85110A09; Thu, 4 Dec 2008 13:15:35 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1L8E3L-0006ih-7s; Thu, 04 Dec 2008 08:15:35 -0500 Date: Thu, 04 Dec 2008 13:16:00 -0000 From: Daniel Jacobowitz To: Doug Evans Cc: gdb-patches@sourceware.org Subject: Re: [RFA] change gdbserver's pids to int Message-ID: <20081204131535.GC24868@caradoc.them.org> Mail-Followup-To: Doug Evans , gdb-patches@sourceware.org References: <20081204012417.1413E1C7A0F@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20081204012417.1413E1C7A0F@localhost> User-Agent: Mutt/1.5.17 (2008-05-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-12/txt/msg00063.txt.bz2 On Wed, Dec 03, 2008 at 05:24:16PM -0800, Doug Evans wrote: > gdb uses an int for a pid (see ptid.pid in defs.h), > and, for example, gdbserver's target_ops.create_inferior returns an int. > For consistency I made pid an int elsewhere in gdbserver, > except for "id" in struct inferior_list - it's used for more than just pids > although I suspect int could be used here too, left for another day. > > Plus this cleans things up by removing local decls of signal_pid. > > Ok to check in? Are you sure that every place you touched gets a system PID, not a thread ID? They used to be ints, but were changed to unsigned long because NPTL's TIDs do not fit in an int. Also, do Windows PIDs fit in an int? Win32 pids must, but I expect we'll get a Win64 port at some point. I'd like to know the advantage before moving all the deck chairs round again. -- Daniel Jacobowitz CodeSourcery