From: Daniel Jacobowitz <drow@false.org>
To: Joel Brobecker <brobecker@adacore.com>
Cc: Tom Tromey <tromey@redhat.com>, Jie Zhang <jie.zhang@analog.com>,
gdb-patches@sourceware.org
Subject: Re: PING: [PATCH] Fix a bug of addrmap
Date: Wed, 26 Nov 2008 14:24:00 -0000 [thread overview]
Message-ID: <20081125175955.GA13721@caradoc.them.org> (raw)
In-Reply-To: <20081125174613.GF3946@adacore.com>
On Tue, Nov 25, 2008 at 09:46:13AM -0800, Joel Brobecker wrote:
> The one comment that I have about this is that it's not automatically
> run when we run the testsuite. It would be really nice if they were.
>
> It's not the first time that we have unit-testing like this.
> For instance, check we have unit tests for observers, or xfullpath.
> Traditionally, they have been implemented inside testsuite/gdb.gdb.
> The current solution is not very elegant, in my opinion, as what we
> did was debugging GDB and call some functions inside GDB.
>
> How about, we add a testcase that "debugs" test-addrmap by simply
> running it to completion and checking its output (including the
> fact that it exited normally (meaning error code returned is zero)?
Could we move this test into a separate file, in gdb.gdb/, and arrange
for it to be linked with libgdb.a?
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2008-11-25 18:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-21 4:44 Jie Zhang
2008-11-03 6:09 ` PING: " Jie Zhang
2008-11-25 23:09 ` Tom Tromey
2008-11-26 6:34 ` Joel Brobecker
2008-11-26 13:53 ` Tom Tromey
2008-11-26 14:24 ` Daniel Jacobowitz [this message]
2008-11-26 15:05 ` Daniel Jacobowitz
2008-11-27 14:45 ` Tom Tromey
2008-12-08 23:12 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081125175955.GA13721@caradoc.them.org \
--to=drow@false.org \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=jie.zhang@analog.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox