From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11123 invoked by alias); 25 Nov 2008 18:00:46 -0000 Received: (qmail 11052 invoked by uid 22791); 25 Nov 2008 18:00:45 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 25 Nov 2008 18:00:06 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 5990210CE0; Tue, 25 Nov 2008 17:59:56 +0000 (GMT) Received: from caradoc.them.org (209.195.188.212.nauticom.net [209.195.188.212]) by nan.false.org (Postfix) with ESMTP id 1895510540; Tue, 25 Nov 2008 17:59:55 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1L52CZ-0003Zj-Gv; Tue, 25 Nov 2008 12:59:55 -0500 Date: Wed, 26 Nov 2008 14:24:00 -0000 From: Daniel Jacobowitz To: Joel Brobecker Cc: Tom Tromey , Jie Zhang , gdb-patches@sourceware.org Subject: Re: PING: [PATCH] Fix a bug of addrmap Message-ID: <20081125175955.GA13721@caradoc.them.org> Mail-Followup-To: Joel Brobecker , Tom Tromey , Jie Zhang , gdb-patches@sourceware.org References: <48FD5DE1.9090105@analog.com> <490E9540.7000207@analog.com> <20081125174613.GF3946@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20081125174613.GF3946@adacore.com> User-Agent: Mutt/1.5.17 (2008-05-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-11/txt/msg00700.txt.bz2 On Tue, Nov 25, 2008 at 09:46:13AM -0800, Joel Brobecker wrote: > The one comment that I have about this is that it's not automatically > run when we run the testsuite. It would be really nice if they were. > > It's not the first time that we have unit-testing like this. > For instance, check we have unit tests for observers, or xfullpath. > Traditionally, they have been implemented inside testsuite/gdb.gdb. > The current solution is not very elegant, in my opinion, as what we > did was debugging GDB and call some functions inside GDB. > > How about, we add a testcase that "debugs" test-addrmap by simply > running it to completion and checking its output (including the > fact that it exited normally (meaning error code returned is zero)? Could we move this test into a separate file, in gdb.gdb/, and arrange for it to be linked with libgdb.a? -- Daniel Jacobowitz CodeSourcery