Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Vladimir Prus <vladimir@codesourcery.com>
To: Daniel Jacobowitz <drow@false.org>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA] -list-target-groups --available
Date: Sun, 23 Nov 2008 02:14:00 -0000	[thread overview]
Message-ID: <200811221938.51061.vladimir@codesourcery.com> (raw)
In-Reply-To: <20081120144226.GA9855@caradoc.them.org>

On Thursday 20 November 2008 17:42:26 Daniel Jacobowitz wrote:
> On Fri, Nov 14, 2008 at 08:03:33PM +0300, Vladimir Prus wrote:
> > 
> > This patch implements MI '-list-target-groups --available' -- for
> > native linux and remote targets. In both cases, the command actually
> > returns the list of processes. The bulk of  the patch was written by 
> > Pedro, I've just added MI bits to it.
> 
> All the code looks OK to me.  However, I would not like to add this
> patch without testcases or documentation.  There should be a DTD
> somewhere, too.

This version has DTD. It also has documentation -- Eli, can you review it.
I did you found a good place where new "info os processes" should be documented,
any suggestions?

I've also added a minimal test for the new functionality -- it basically makes
sure we can get some process list, when using gdbserver on linux. Given that it's
very system-dependent, I don't think we can do better.

> 
> > +void
> > +_initialize_osdata (void)
> > +{
> > +  add_info ("os", info_osdata_command,
> > +           _("Show OS data ARG."));
> > +
> > +  /* An alias for "info osdata processes".  */
> > +  add_info ("processes", info_processes_command,
> > +           _("List running processes on the target."));
> > +}
> 
> "info os processes" or "info osdata"?

I wonder if the alias should be dropped -- "info processes" can
be easily confused with "info inferiors".

- Volodya


  reply	other threads:[~2008-11-22 16:39 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-14 18:55 Vladimir Prus
2008-11-21  0:46 ` Daniel Jacobowitz
2008-11-23  2:14   ` Vladimir Prus [this message]
2008-11-23  5:16     ` Vladimir Prus
2008-11-24 22:11       ` Daniel Jacobowitz
2008-11-23 16:11     ` Pedro Alves
2008-11-24 23:13     ` Eli Zaretskii
2008-11-25  2:41       ` Eli Zaretskii
2008-12-01  8:12         ` Vladimir Prus
2008-12-01 20:39           ` Eli Zaretskii
2008-11-25  6:13     ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200811221938.51061.vladimir@codesourcery.com \
    --to=vladimir@codesourcery.com \
    --cc=drow@false.org \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox